Review main Merged

67096[TASK] Enforce shortcut title to be set by controllers

Oli Bartsch CR +2 V +2 Hard +318 −48 updated 12/14/20, 20:19

Commit message

The ShortcutRepository should not deal with generating
shortcut titles based on the provided arguments. This can
never be reliable, especially for custom extension code.
The appropriate title must be set by the calling controller
since this is the place where all necessary information,
to define such title, are available.

Therefore, adding a new shortcut button without defining
a display name is deprecated. All Core controllers are
adjusted to provide the necessary title themself.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 17

Review log 816

  1. Oli Bartsch uploaded patch set 1 12/11/20, 14:59

  2. TYPO3com voted on patch set 1 V -1 12/11/20, 15:09 Completed build in 09m 51s on Fri, 11 Dec, 03:09 PM Test Summary: 31582 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8080

  3. Oli Bartsch uploaded patch set 2 12/14/20, 10:06

  4. TYPO3com voted on patch set 2 V -1 12/14/20, 10:06 Completed build in 23s on Mon, 14 Dec, 10:06 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8148

  5. Oli Bartsch uploaded patch set 3 12/14/20, 13:35

  6. TYPO3com voted on patch set 3 V -1 12/14/20, 13:36 Completed build in 32s on Mon, 14 Dec, 01:36 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8162

  7. Oli Bartsch uploaded patch set 4 12/14/20, 14:29

  8. TYPO3com voted on patch set 4 V -1 12/14/20, 14:39 Completed build in 10m 14s on Mon, 14 Dec, 02:39 PM Test Summary: 31309 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8166

  9. TYPO3com commented on patch set 4 12/14/20, 14:51 Completed build in 10m 57s on Mon, 14 Dec, 02:51 PM Test Summary: 1 of 32656 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8167

  10. TYPO3com voted on patch set 4 V +1 12/14/20, 15:02 Completed build in 32m 52s on Mon, 14 Dec, 03:02 PM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8167

  11. Oli Bartsch uploaded patch set 5 12/14/20, 16:59

  12. TYPO3com voted on patch set 5 V -1 12/14/20, 17:09 Completed build in 09m 16s on Mon, 14 Dec, 05:09 PM Test Summary: 1 of 32656 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8173

  13. TYPO3com voted on patch set 5 V +1 12/14/20, 17:25 Completed build in 34m 39s on Mon, 14 Dec, 05:25 PM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8173

  14. Christian Kuhn voted on patch set 5 V +1 CR +1 12/14/20, 17:28

  15. Benni Mack voted on patch set 5 V +2 CR +2 12/14/20, 20:19

  16. Benni Mack merged patch set 6 12/14/20, 20:19