Review main Merged

67097[TASK] Allow flushing of the internal StorageRepository cache

Alexander Nitsche CR +2 V +2 Easy +15 −3 updated 12/14/20, 21:16

Commit message

To explicitly refresh the internal cache of StorageRepository
when a file storage has been added/removed/updated, a public
method flush() has been added to the class.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Simon Gilli +1
    • Wouter Wolters +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1012

  1. Alexander Nitsche uploaded patch set 1 12/11/20, 15:24

  2. TYPO3com voted on patch set 1 V -1 12/11/20, 15:34 Completed build in 09m 05s on Fri, 11 Dec, 03:34 PM Test Summary: 10 of 32654 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8081

  3. Alexander Nitsche commented on patch set 1 12/11/20, 15:35

    Unresolved

    Hi guys, would be great if you could have a look at this small patch: It would allow me to streamline the storage handling in EXT:impexp and it is about flushing the internal storage records cache, e.g. when a new storage record has been imported. The new method flush() clears all 3 internal arrays which belong to formerly fetched storage records and i replaced all internal clearing by the new method. I tested it with XDebug and TYPO3 v11 of 120 commits ago and run all functional tests of the Core, but i did not add a new test. Tell me, if you think it should have one. Thank you, Alex
  4. TYPO3com voted on patch set 1 V +1 12/11/20, 16:00 Completed build in 44m 10s on Fri, 11 Dec, 04:00 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8081

  5. Oli Bartsch commented on patch set 1 12/11/20, 17:12

    StorageRepository.php:189

    Since this method is only used in this class, I suggest declaring its visibility protected and to remove the @internal annotation.
  6. Benni Mack commented on patch set 1 12/11/20, 17:16

    StorageRepository.php:189 Reply

    This is built because this change is the pre-cursor for an improvement in ImpExp.
  7. Oli Bartsch commented on patch set 1 12/11/20, 17:29

    StorageRepository.php:189 Reply

    Ack
  8. Benni Mack voted on patch set 1 CR +1 12/11/20, 18:22

  9. Simon Gilli voted on patch set 1 CR +1 12/11/20, 20:47

  10. Wouter Wolters voted on patch set 1 CR +1 12/11/20, 21:11

  11. Georg Ringer voted on patch set 1 V +2 CR +2 12/14/20, 21:16

  12. Georg Ringer merged patch set 2 12/14/20, 21:16