67097[TASK] Allow flushing of the internal StorageRepository cache
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Simon Gilli +1
- Wouter Wolters +1
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1012
-
Alexander Nitsche uploaded patch set 1 12/11/20, 15:24
-
TYPO3com voted on patch set 1 V -1 12/11/20, 15:34 Completed build in 09m 05s on Fri, 11 Dec, 03:34 PM Test Summary: 10 of 32654 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8081
-
Alexander Nitsche commented on patch set 1 12/11/20, 15:35
-
TYPO3com voted on patch set 1 V +1 12/11/20, 16:00 Completed build in 44m 10s on Fri, 11 Dec, 04:00 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8081
-
Oli Bartsch commented on patch set 1 12/11/20, 17:12
StorageRepository.php:189Since this method is only used in this class, I suggest declaring its visibility protected and to remove the @internal annotation. -
Benni Mack commented on patch set 1 12/11/20, 17:16
StorageRepository.php:189ReplyThis is built because this change is the pre-cursor for an improvement in ImpExp. -
Oli Bartsch commented on patch set 1 12/11/20, 17:29
StorageRepository.php:189ReplyAck -
Benni Mack voted on patch set 1 CR +1 12/11/20, 18:22
-
Simon Gilli voted on patch set 1 CR +1 12/11/20, 20:47
-
Wouter Wolters voted on patch set 1 CR +1 12/11/20, 21:11
-
Georg Ringer voted on patch set 1 V +2 CR +2 12/14/20, 21:16
-
Georg Ringer merged patch set 2 12/14/20, 21:16
Unresolved