Review main Merged

67098[FEATURE] Store Flash Messages as JsonSerializable

Benni Mack CR +2 V +2 Normal +65 −2 updated 12/12/20, 14:07

Commit message

Flash Messages which should be stored in sessions,
are now stored as stringified JsonSerializable instead of
their objects themselves.

The huge advantages over the previous functionality
is that the FlashMessage objects are not instantiated during the process
when a session is loaded, but actually only when the FlashMessages
are needed, bringing a bit of performance for Backend functionality.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 2231

Show 56 earlier messages
  1. Benni Mack uploaded patch set 1 12/11/20, 18:04

  2. TYPO3com voted on patch set 1 V -1 12/11/20, 18:13 Completed build in 09m 20s on Fri, 11 Dec, 06:13 PM Test Summary: 3478 of 32654 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8085

  3. Oliver Klee commented on patch set 1 CR -1 12/11/20, 18:19

    This change also needs an issue number.

    UserSession.php:229

    Shouldn't we limit the allowed classes here in order to increase security? Also, now we'll run into PHP notices if $record['ses_data'] is not set or is no string.
  4. Benni Mack commented on patch set 1 12/11/20, 18:21

    sorry, yes, this patch is still WIP.
  5. Benni Mack marked it work in progress 12/11/20, 18:21

  6. Benni Mack uploaded patch set 2 12/11/20, 20:14

  1. Benni Mack marked it ready for review 12/11/20, 20:14

  2. TYPO3com voted on patch set 2 V -1 12/11/20, 20:29 Completed build in 12m 00s on Fri, 11 Dec, 08:29 PM Test Summary: 6 of 32258 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8094

  3. Benni Mack uploaded patch set 3 12/11/20, 20:36

  4. Benni Mack commented on patch set 3 12/11/20, 20:36

    Reply

    Ack

    UserSession.php:229 Reply

    Ack
  5. Benni Mack uploaded patch set 4 12/11/20, 20:37

  6. Oliver Klee wrote 12/11/20, 20:42

    Removed reviewer Oliver Klee.
  7. Oliver Klee commented on patch set 4 12/11/20, 20:44

    FlashMessage.php:53 Unresolved

    array<string, string|int>, or maybe array<string, string|int|bool>?

    FlashMessageQueue.php:156

    We can make the anonymous function static and add parameter and return type declarations here.
  8. TYPO3com voted on patch set 3 V -1 12/11/20, 20:45 Completed build in 09m 10s on Fri, 11 Dec, 08:45 PM Test Summary: 2 of 32652 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8095

  9. TYPO3com voted on patch set 4 V -1 12/11/20, 20:49 Completed build in 12m 03s on Fri, 11 Dec, 08:49 PM Test Summary: 2 of 32652 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8096

  10. Oliver Hader commented on patch set 4 12/11/20, 21:07

    FlashMessageQueue.php:156 Reply

    Much simpler: `array_map('json_encode', $messages);`
  11. Benni Mack commented on patch set 4 12/11/20, 22:37

    FlashMessageQueue.php:156 Reply

    Ah, even better. @Oli what do you think about that one?
  12. Oliver Klee commented on patch set 4 12/11/20, 23:04

    FlashMessageQueue.php:156 Reply Unresolved

    I like it!
  13. Christian Kuhn voted on patch set 4 CR +1 12/12/20, 12:40

  14. Benni Mack uploaded patch set 5 12/12/20, 12:50

  15. Christian Kuhn voted on patch set 5 V +1 CR +1 12/12/20, 12:57

  16. TYPO3com voted on patch set 5 V -1 12/12/20, 13:01 Completed build in 11m 23s on Sat, 12 Dec, 01:01 PM Test Summary: 14 of 28103 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8116

  17. TYPO3com commented on patch set 5 12/12/20, 13:18 Completed build in 39m 54s on Sat, 12 Dec, 01:18 PM Test Summary: 2 of 32655 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8116

  18. Benni Mack uploaded patch set 6 12/12/20, 13:26

  19. TYPO3com commented on patch set 5 12/12/20, 13:33 Completed build in 1h 23m 17s on Sat, 12 Dec, 01:33 PM Test Summary: 2 of 32655 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8116

  20. TYPO3com voted on patch set 6 V -1 12/12/20, 13:38 Completed build in 12m 01s on Sat, 12 Dec, 01:38 PM Test Summary: 32414 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8118

  21. Andreas Kienast uploaded patch set 7 12/12/20, 13:42

  22. TYPO3com voted on patch set 7 V +1 12/12/20, 13:52 Completed build in 09m 48s on Sat, 12 Dec, 01:52 PM Test Summary: 32414 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8119

  23. Christian Kuhn voted on patch set 7 V +1 CR +1 12/12/20, 13:56

  24. Andreas Kienast voted on patch set 7 V +2 CR +2 12/12/20, 14:07

  25. Andreas Kienast merged patch set 8 12/12/20, 14:07