Review main Merged Breaking

67099[!!!][TASK] Remove group-related properties in BE_USER

Benni Mack CR +2 V +2 Normal +183 −37 updated 12/12/20, 12:43

Commit message

The "$BE_USER->groupList" property is a comma-separated list
of userGroupUID, whereas "$BE_USER->includeGroupArray"
is a list of groups added to the includeGroupArray
which contains groups possibly added multiple times due
to recursion.

This is not needed, and therefore cleaned up,
the properties are removed.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 815

  1. Benni Mack uploaded patch set 1 12/11/20, 19:23

  2. TYPO3com voted on patch set 1 V -1 12/11/20, 19:35 Completed build in 11m 46s on Fri, 11 Dec, 07:35 PM Test Summary: 31249 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8088

  3. Benni Mack updated the commit message in patch set 2 12/11/20, 19:37

  4. TYPO3com voted on patch set 1 V +1 12/11/20, 19:44 Completed build in 32m 21s on Fri, 11 Dec, 07:44 PM Test Summary: 32414 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8088

  5. TYPO3com voted on patch set 2 V +1 12/11/20, 19:48 Completed build in 10m 19s on Fri, 11 Dec, 07:48 PM Test Summary: 32414 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8089

  6. Benni Mack uploaded patch set 3 12/11/20, 20:51

  7. TYPO3com voted on patch set 3 V -1 12/11/20, 21:05 Completed build in 12m 18s on Fri, 11 Dec, 09:04 PM Test Summary: 31350 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8099

  8. Wouter Wolters commented on patch set 3 CR +1 12/11/20, 21:06

    Breaking-93062-VariousGroup-relatedPublicPropertiesInBE_USERRemoved.rst:40 Unresolved

    group UIDs maybe?
  9. TYPO3com voted on patch set 3 V +1 12/11/20, 22:52 Completed build in 2h 12m 13s on Fri, 11 Dec, 10:52 PM Test Summary: 32414 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8099

  10. Benni Mack commented on patch set 4 12/12/20, 12:05

    Published edit on patch set 3.
  11. TYPO3com voted on patch set 4 V -1 12/12/20, 12:17 Completed build in 11m 52s on Sat, 12 Dec, 12:17 PM Test Summary: 1 of 31847 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8112

  12. Christian Kuhn voted on patch set 4 V +1 CR +1 12/12/20, 12:26

  13. TYPO3com voted on patch set 4 V +1 12/12/20, 12:30 Completed build in 36m 53s on Sat, 12 Dec, 12:30 PM Test Summary: 32414 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8112

  14. Andreas Kienast voted on patch set 4 V +2 CR +2 12/12/20, 12:43

  15. Andreas Kienast merged patch set 5 12/12/20, 12:43