6710[BUGFIX] typolink prepends wrong domain when using url scheme
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
- Steffen Ritter +1
-
Verified V +2
- Oliver Hader +2
- Steffen Ritter +1
Issues 1
Files 1
Review log 15
-
Dmitry Dulepov commented on patch set 1 01/24/12, 09:25
No, it is not necessary. I have no idea why gerrit adds it. -
Markus Klein commented on patch set 1 01/24/12, 09:25
The dependency is not necessary, is it? -
Markus Klein commented on patch set 1 01/24/12, 09:25
I guess you have to clean your local branch and push it again. -
Dmitry Dulepov uploaded patch set 3 01/24/12, 09:25
-
Markus Klein commented on patch set 2 01/24/12, 09:25
Repushed it to remove the dependency. -
Markus Klein uploaded patch set 2 01/24/12, 09:25
-
Markus Klein commented on patch set 2 01/24/12, 09:25
I would prefer that you didn't submit this Please vote in master first: https://review.typo3.org/6708 -
Markus Klein commented on patch set 3 01/24/12, 09:25
What's changed in set 3? -
Markus Klein commented on patch set 4 01/24/12, 09:25
I would prefer that you didn't submit this Has to wait for master. Review there: https://review.typo3.org/6708 -
Markus Klein commented on patch set 4 01/24/12, 09:25
No score -
Oliver Hader commented on patch set 4 V 0 01/24/12, 09:25
by team member; Looks good to me, approved -
Oliver Hader uploaded patch set 4 01/24/12, 09:25
-
Oliver Hader commented on patch set 4 01/24/12, 09:25
Automated rebasing to TYPO3_4-5 - Please consider updating your reviews V:0, R:0 as a summary of previous scores (limited to [-1;+1]) -
Steffen Ritter commented on patch set 4 01/24/12, 09:25
Verified; Looks good to me, but someone else must approve -
Oliver Hader merged patch set 4 01/24/12, 09:25