Review TYPO3_4-5 Merged

6710[BUGFIX] typolink prepends wrong domain when using url scheme

Dmitry Dulepov CR +2 V +2 Easy +5 −5 updated 06/03/13, 20:49

Commit message

tslib_cObj::typoLink() uses a wrong domain if the target page
has a domain record and a URL scheme, which is different to
current. It prepends a current domain instead of the target
domain of the page.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Steffen Ritter +1
  • Verified V +2
    • Oliver Hader +2
    • Steffen Ritter +1

Issues 1

Files 1

Review log 15

  1. Dmitry Dulepov commented on patch set 1 01/24/12, 09:25

    No, it is not necessary. I have no idea why gerrit adds it.
  2. Markus Klein commented on patch set 1 01/24/12, 09:25

    The dependency is not necessary, is it?
  3. Markus Klein commented on patch set 1 01/24/12, 09:25

    I guess you have to clean your local branch and push it again.
  4. Dmitry Dulepov uploaded patch set 3 01/24/12, 09:25

  5. Markus Klein commented on patch set 2 01/24/12, 09:25

    Repushed it to remove the dependency.
  6. Markus Klein uploaded patch set 2 01/24/12, 09:25

  7. Markus Klein commented on patch set 2 01/24/12, 09:25

    I would prefer that you didn't submit this Please vote in master first: https://review.typo3.org/6708
  8. Markus Klein commented on patch set 3 01/24/12, 09:25

    What's changed in set 3?
  9. Markus Klein commented on patch set 4 01/24/12, 09:25

    I would prefer that you didn't submit this Has to wait for master. Review there: https://review.typo3.org/6708
  10. Markus Klein commented on patch set 4 01/24/12, 09:25

    No score
  11. Oliver Hader commented on patch set 4 V 0 01/24/12, 09:25

    by team member; Looks good to me, approved
  12. Oliver Hader uploaded patch set 4 01/24/12, 09:25

  13. Oliver Hader commented on patch set 4 01/24/12, 09:25

    Automated rebasing to TYPO3_4-5 - Please consider updating your reviews V:0, R:0 as a summary of previous scores (limited to [-1;+1])
  14. Steffen Ritter commented on patch set 4 01/24/12, 09:25

    Verified; Looks good to me, but someone else must approve
  15. Oliver Hader merged patch set 4 01/24/12, 09:25