67100[BUGFIX] Properly discard workspace MM relations
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 22
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+44 −9
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/Discard/DataSet/addCategoryRelation.csv+0 −4
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/Discard/DataSet/changeCategoryRelationSorting.csv+0 −3
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/Discard/DataSet/copyCategoryOfRelation.csv+0 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/Discard/DataSet/copyContentOfRelation.csv+0 −3
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/Discard/DataSet/copyPage.csv+0 −5
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/Discard/DataSet/createCategoryNAddRelation.csv+0 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/Discard/DataSet/createCategoryNCreateRelation.csv+0 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/Discard/DataSet/createCategoryWContentNAddRelation.csv+0 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/Discard/DataSet/createContentNAddRelation.csv+0 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/Discard/DataSet/createContentNCreateRelation.csv+0 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/Discard/DataSet/createContentWCategoryNAddRelation.csv+0 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/Discard/DataSet/deleteCategoryOfRelation.csv+0 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/Discard/DataSet/deleteCategoryRelation.csv+0 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/Discard/DataSet/deleteContentOfRelation.csv+0 −3
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/Discard/DataSet/localizeCategoryOfRelation.csv+0 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/Discard/DataSet/localizeContentOfRelation.csv+0 −3
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/Discard/DataSet/modifyBothsOfRelation.csv+0 −3
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/Discard/DataSet/modifyCategoryOfRelation.csv+0 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/Discard/DataSet/modifyContentOfRelation.csv+0 −3
Review log 1118
-
Christian Kuhn uploaded patch set 1 12/11/20, 19:54
-
TYPO3com voted on patch set 1 V -1 12/11/20, 20:05 Completed build in 10m 47s on Fri, 11 Dec, 08:05 PM Test Summary: 1 of 32652 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8091
-
Christian Kuhn uploaded patch set 2 12/11/20, 20:08
-
TYPO3com voted on patch set 2 V -1 12/11/20, 20:23 Completed build in 14m 53s on Fri, 11 Dec, 08:23 PM Test Summary: 30301 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8092
-
TYPO3com voted on patch set 2 V +1 12/11/20, 20:32 Completed build in 39m 12s on Fri, 11 Dec, 08:32 PM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8092
-
Christian Kuhn uploaded patch set 3 12/11/20, 20:59
-
TYPO3com voted on patch set 3 V -1 12/11/20, 21:11 Completed build in 11m 27s on Fri, 11 Dec, 09:11 PM Test Summary: 18 of 31514 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8100
-
Christian Kuhn uploaded patch set 4 12/11/20, 21:29
-
TYPO3com voted on patch set 4 V -1 12/11/20, 21:40 Completed build in 11m 29s on Fri, 11 Dec, 09:40 PM Test Summary: 28409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8101
-
Christian Kuhn uploaded patch set 5 12/11/20, 21:45
-
TYPO3com voted on patch set 5 V +1 12/11/20, 22:01 Completed build in 13m 09s on Fri, 11 Dec, 10:01 PM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8102
-
Christian Kuhn updated the commit message in patch set 6 12/11/20, 22:06
-
TYPO3com voted on patch set 6 V +1 12/11/20, 22:23 Completed build in 16m 42s on Fri, 11 Dec, 10:23 PM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8103
-
Benni Mack commented on patch set 6 12/11/20, 22:53
This means, the MM relations are deleted, but not the foreign record, right? -
Christian Kuhn commented on patch set 6 12/11/20, 23:15
Reply
yes -
Benni Mack voted on patch set 6 V +1 CR +1 12/12/20, 10:27
-
Andreas Kienast voted on patch set 6 V +2 CR +2 12/12/20, 14:39
-
Andreas Kienast merged patch set 7 12/12/20, 14:39