Review main Merged

67102[BUGFIX] Add missing (int) cast when creating preview uri

Markus Klein CR +2 V +2 Easy +2 −2 updated 12/12/20, 10:32

Commit message

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 67

  1. Markus Klein uploaded patch set 1 12/12/20, 10:01

  2. TYPO3com voted on patch set 1 V +1 12/12/20, 10:14 Completed build in 12m 53s on Sat, 12 Dec, 10:14 AM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8109

  3. Oliver Klee commented on patch set 1 CR +1 12/12/20, 10:24

    Does this also affect 10.4 and 9.5?
  4. Benni Mack commented on patch set 1 V +1 CR +1 12/12/20, 10:26

    Thanks, issues on SQLite
  5. Oliver Hader commented on patch set 1 12/12/20, 10:27

    Could not reproduce, which DBMS/Driver is used here?
  6. Oliver Hader commented on patch set 1 V +2 CR +2 12/12/20, 10:32

    At least the cast does not hurt...
  7. Oliver Hader merged patch set 2 12/12/20, 10:32