Review main Merged

67105[TASK] Harden client-side SecurityUtility.encodeHtml

Oliver Hader CR +2 V +2 Easy +9 −3 updated 12/13/20, 20:21

Commit message

Ensures client-side function `SecurityUtility.encodeHtml` behaves like
`htmlspecialchars(..., ENT_QUOTES)`. The function is used for complete
nodes only, but now could be used for parts as well.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Torben Hansen +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 56

  1. Oliver Hader uploaded patch set 1 12/13/20, 09:03

  2. TYPO3com voted on patch set 1 V +1 12/13/20, 09:13 Completed build in 09m 31s on Sun, 13 Dec, 09:13 AM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8130

  3. Markus Klein voted on patch set 1 V +1 CR +1 12/13/20, 13:54

  4. Torben Hansen voted on patch set 1 V +1 CR +1 12/13/20, 17:37

  5. Benni Mack voted on patch set 1 V +2 CR +2 12/13/20, 20:21

  6. Benni Mack merged patch set 2 12/13/20, 20:21