Review main Merged

67108[BUGFIX] Initialize strictly typed property setCookie with null

Daniel Goerz CR +2 V +2 Easy +2 −2 updated 12/14/20, 13:14

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Daniel Goerz uploaded patch set 1 12/13/20, 11:17

  2. TYPO3com voted on patch set 1 V +1 12/13/20, 11:29 Completed build in 11m 06s on Sun, 13 Dec, 11:29 AM Test Summary: 32414 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8132

  3. Oliver Klee voted on patch set 1 CR +1 12/13/20, 13:25

  4. Benjamin Franzke commented on patch set 1 12/14/20, 11:57

    AbstractUserAuthentication.php:288

    Let's also change this to $this->setCookie !== null then. Feels more natural, now that it is initialized to null.
  5. Daniel Goerz uploaded patch set 2 12/14/20, 12:29

  6. TYPO3com voted on patch set 2 V +1 12/14/20, 12:41 Completed build in 11m 40s on Mon, 14 Dec, 12:41 PM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8155

  7. Andreas Kienast voted on patch set 2 V +1 CR +1 12/14/20, 12:51

  8. Daniel Goerz commented on patch set 2 12/14/20, 13:01

    AbstractUserAuthentication.php:288 Reply

    Done
  9. Christian Kuhn voted on patch set 2 V +2 CR +2 12/14/20, 13:14

  10. Christian Kuhn merged patch set 3 12/14/20, 13:14