Review main Merged

67109[BUGFIX] DBAL: Do not use deprecated classes

Benni Mack CR +2 V +2 Normal +72 −72 updated 12/14/20, 13:01

Commit message

In preparation for Doctrine DBAL 3.0,

1. all usages of Doctrine\DBAL\DBALException have
been migrated to Doctrine\DBAL\Exception,
because DBAL Exception does not exist in
Doctrine 3.0 anymore.

2. Doctrine\DBAL\Platforms\PostgreSqlPlatform
has been migrated to Doctrine\DBAL\Platforms\PostgreSQL94Platform
because this class does not exist anymore in Doctrine DBAL 3.0,
same goes for Doctrine\DBAL\Platforms\SQLServerPlatform
which has been replaced by Doctrine\DBAL\Platforms\SQLServer2012Platform

3. Doctrine\DBAL\Driver\PDOException has been
renamed to Doctrine\DBAL\Driver\PDO\Exception

4. Doctrine\DBAL\Driver\PDOStatement has been
renamed to Doctrine\DBAL\Driver\PDO\Statement

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 46

Show 26 more files

Review log 813

  1. Benni Mack uploaded patch set 1 12/13/20, 19:42

  2. TYPO3com voted on patch set 1 V -1 12/13/20, 19:53 Completed build in 11m 01s on Sun, 13 Dec, 07:53 PM Test Summary: 29906 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8136

  3. TYPO3com voted on patch set 1 V +1 12/13/20, 20:01 Completed build in 30m 00s on Sun, 13 Dec, 08:01 PM Test Summary: 32414 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8136

  4. Benni Mack uploaded patch set 2 12/13/20, 20:18

  5. TYPO3com voted on patch set 2 V -1 12/13/20, 20:39 Completed build in 15m 40s on Sun, 13 Dec, 08:39 PM Test Summary: 3 of 30846 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8138

  6. TYPO3com voted on patch set 2 V +1 12/13/20, 20:54 Completed build in 46m 00s on Sun, 13 Dec, 08:54 PM Test Summary: 32414 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8138

  7. Oli Bartsch uploaded patch set 3 12/14/20, 09:33

  8. Oli Bartsch voted on patch set 3 V +1 CR +1 12/14/20, 09:36

  9. TYPO3com voted on patch set 3 V +1 12/14/20, 09:43 Completed build in 09m 54s on Mon, 14 Dec, 09:43 AM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8144

  10. Christian Kuhn commented on patch set 3 CR -1 12/14/20, 12:50

    on it.
  11. Christian Kuhn voted on patch set 3 V +1 CR +1 12/14/20, 13:00

  12. Christian Kuhn voted on patch set 3 V +2 CR +2 12/14/20, 13:01

  13. Christian Kuhn merged patch set 4 12/14/20, 13:01