Review main Merged

67115[TASK] DBAL: Extend custom drivers from abstract drivers

Benni Mack CR +2 V +2 Normal +148 −19 updated 12/14/20, 20:41

Commit message

TYPO3 Core has its own implementation of driver classes
for database abstraction by effectively overriding e.g.
the PDO Statement class with TYPO3's Statment class
to ensure that resources are strings to be completely
transparent with Database abstraction.

Doctrine DBAL 3.0 will force Drivers to either
switch to composition or extend from the Abstract Driver classes.

This change switches TYPO3's native implementation
to extend from Abstract Driver classes, ensuring
forward-compatibility with Doctrine DBAL 3.0
for TYPO3 v11 with Drivers.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 57

  1. Benni Mack uploaded patch set 1 12/14/20, 17:07

  2. TYPO3com voted on patch set 1 V +1 12/14/20, 17:17 Completed build in 09m 39s on Mon, 14 Dec, 05:17 PM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8174

  3. Oli Bartsch uploaded patch set 2 12/14/20, 19:16

  4. TYPO3com voted on patch set 2 V +1 12/14/20, 19:25 Completed build in 08m 47s on Mon, 14 Dec, 07:25 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8177

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 12/14/20, 19:25

  6. Georg Ringer voted on patch set 2 V +2 CR +2 12/14/20, 20:41

  7. Georg Ringer merged patch set 3 12/14/20, 20:41