Review main Merged

6712[BUGFIX] Error in the pageNotFound_handling with USER_FUNCTION

Dmitry Dulepov CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

When using USER_FUNCTION in the pageNotFound_handling, an exception
or a blank screen appears in the Frontend (depending on error
handling settings) because $GLOBALS['TSFE']->sys_page is not
initialized.

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Stefan Neufeind +1
  • Verified V +2
    • Xavier Perseguers +2

Issues 1

Files 1

Review log 9

  1. Dmitry Dulepov uploaded patch set 2 11/22/11, 14:22

  2. Dmitry Dulepov uploaded patch set 3 11/22/11, 14:22

  3. Stefan Neufeind commented on patch set 3 11/22/11, 14:22

    Looks good to me, but someone else must approve
  4. Xavier Perseguers commented on patch set 3 V 0 11/22/11, 14:22

    by team member; Looks good to me, approved nobrainer
  5. Xavier Perseguers commented on patch set 3 11/22/11, 14:22

    Looks good to me, but someone else must approve
  6. Mr. Jenkins commented on patch set 1 11/22/11, 14:22

  7. Mr. Jenkins commented on patch set 2 11/22/11, 14:22

  8. Mr. Jenkins commented on patch set 3 11/22/11, 14:22

  9. Xavier Perseguers merged patch set 3 11/22/11, 14:22