Review main Merged Breaking

67137[!!!][BUGFIX] Do not cache a BE users' group list

Benni Mack CR +2 V +2 Hard +234 −171 updated 12/15/20, 17:16

Commit message

When a user logs in, the "cache" field "usergroup_cached_list"
is updated in the be_users table.

This value is used so the groups do not need to be recalculated
each time for each user (e.g. in Workspaces when sending
notifications and in Log module).

However, this has serious flaws:
1) If an admin removes a previously active user from a BE
   group, the cached list still contains the old group, until
   the user logs in
2) If a user never logged in before, the list is empty

This change removes this conceptual bug, and builds this
into the GroupResolver to use direct (optimized) DB queries
for these use cases, making the DB field obsolete.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 915

  1. Benni Mack uploaded patch set 1 12/15/20, 11:16

  2. TYPO3com voted on patch set 1 V +1 12/15/20, 11:26 Completed build in 09m 07s on Tue, 15 Dec, 11:26 AM Test Summary: 32412 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8190

  3. Christian Kuhn commented on patch set 1 12/15/20, 11:34

    Great patch!
    forge has at least one quite old issue about this field.
  4. Benni Mack uploaded patch set 2 12/15/20, 13:08

  5. TYPO3com voted on patch set 2 V -1 12/15/20, 13:19 Completed build in 10m 35s on Tue, 15 Dec, 01:19 PM Test Summary: 32064 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8193

  6. Benni Mack uploaded patch set 3 12/15/20, 13:51

  7. TYPO3com voted on patch set 3 V -1 12/15/20, 14:02 Completed build in 10m 53s on Tue, 15 Dec, 02:02 PM Test Summary: 30286 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8196

  8. TYPO3com voted on patch set 3 V +1 12/15/20, 14:17 Completed build in 36m 51s on Tue, 15 Dec, 02:17 PM Test Summary: 32433 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8196

  9. Benni Mack commented on patch set 3 12/15/20, 15:21

    Reply

    thank you!

    Reply

    Ack
  10. Christian Kuhn uploaded patch set 4 12/15/20, 15:57

  11. Christian Kuhn voted on patch set 4 V +1 CR +1 12/15/20, 15:58

  12. TYPO3com voted on patch set 4 V -1 12/15/20, 16:08 Completed build in 10m 24s on Tue, 15 Dec, 04:08 PM Test Summary: 32424 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8201

  13. TYPO3com voted on patch set 4 V +1 12/15/20, 16:13 Completed build in 26m 36s on Tue, 15 Dec, 04:13 PM Test Summary: 32433 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8201

  14. Georg Ringer voted on patch set 4 V +2 CR +2 12/15/20, 17:16

  15. Georg Ringer merged patch set 5 12/15/20, 17:16