Review main Merged Breaking

67138[!!!][TASK] Protect RelationHandler internals

Christian Kuhn CR +2 V +2 Normal +201 −23 updated 12/15/20, 22:59

Commit message

Class RelationHandler is a confusing mess with tons
of state spread over 28 class properties and 35
consuming methods. Nearly everything is public and
of course far from bug free.

The patch protects a series of properties and methods
that handle internal state and do not need to be
accessed from outside. For instance, the same state
created by the 'read' methods is done by start().

This is a starter patch to allow refactorings
towards a better manageable codebase.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 710

  1. Christian Kuhn uploaded patch set 1 12/15/20, 12:20

  2. TYPO3com voted on patch set 1 V +1 12/15/20, 12:31 Completed build in 11m 02s on Tue, 15 Dec, 12:31 PM Test Summary: 32412 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8191

  3. Christian Kuhn uploaded patch set 2 12/15/20, 13:09

  4. Christian Kuhn voted on patch set 2 CR -1 12/15/20, 13:13

  5. Christian Kuhn uploaded patch set 3 12/15/20, 13:15

  6. TYPO3com voted on patch set 2 V +1 12/15/20, 13:22 Completed build in 12m 48s on Tue, 15 Dec, 01:22 PM Test Summary: 32412 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8194

  7. TYPO3com voted on patch set 3 V +1 12/15/20, 13:26 Completed build in 10m 12s on Tue, 15 Dec, 01:26 PM Test Summary: 32412 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8195

  8. Anja Leichsenring voted on patch set 3 V +1 CR +1 12/15/20, 17:44

  9. Georg Ringer voted on patch set 3 V +2 CR +2 12/15/20, 22:59

  10. Georg Ringer merged patch set 4 12/15/20, 22:59