Review 10.4 Abandoned

67140[BUGFIX] Fetch localized record uid from the current page only

Dmitry Dulepov CR 0 V 0 Easy +1 −1 updated 10/20/21, 01:27

Commit message

DataHandler typically adds a pid clause to all queries when fetching
localized records. However this clause is missing in one place. If
there are translated elements that are on a different page then the
parent element's page, getPreviousLocalizedRecordUid() function
will find them while other functions will not. Such behavior will
corrupt data. This change makes sure that the function behaves
in the same way as other calls to fetch localized records.

This fix is contributed by the University of Basel.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 45

  1. Dmitry Dulepov uploaded patch set 1 12/15/20, 12:34

  2. Dmitry Dulepov commented on patch set 1 12/15/20, 12:46

    Unresolved

    If you are wondering how to test it, it can be complicated. We had it with several pages, some translated, some not, gridelements, and a couple of copy/paste actions. In the end there were translations on a different page than the page from the "translation source" elements. When localizing such translation source, elements from a different page were found and more wrong elements and data was created making neither translations possible, nor elements showing anywhere. This change limits to TYPO3 to fetching translation from the current page only, which is correct. It does not solve the original problem though, which is hard to trace to the error source. But it makes TYPO3 translate elements on the current page correctly.
  3. TYPO3com voted on patch set 1 V +1 12/15/20, 12:50 Completed build in 15m 05s on Tue, 15 Dec, 12:50 PM Test Summary: 75238 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-916

  4. Christian Kuhn commented on patch set 1 10/20/21, 01:25

    This has been fixed with codewise basically the same fix in https://review.typo3.org/c/Packages/TYPO3.CMS/+/66552
  5. Christian Kuhn abandoned the change 10/20/21, 01:27