67143[!!!][TASK] Rework shortcut PHP API functionality
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Daniel Goerz +1
-
Verified V +2 Done
- Christian Kuhn +2
- Daniel Goerz +1
- TYPO3com +1 CI
Issues 1
Files 49
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Toolbar/ShortcutMenu.ts+10 −13
- typo3/sysext/backend/Classes/Backend/Shortcut/ShortcutRepository.php2+151 −226
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+1 −2
- typo3/sysext/backend/Classes/Controller/HelpController.php+1 −2
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+1 −2
- typo3/sysext/backend/Classes/Controller/ShortcutController.php+7 −7
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php+1 −1
- typo3/sysext/backend/Classes/Template/Components/Buttons/Action/ShortcutButton.php+155 −33
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php+49 −17
- typo3/sysext/backend/Classes/ViewHelpers/ModuleLayout/Button/ShortcutButtonViewHelper.php+25 −4
- typo3/sysext/backend/Configuration/Services.yaml+3 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Toolbar/ShortcutMenu.js+1 −1
- typo3/sysext/backend/Tests/Functional/Backend/Fixtures/ShortcutsAddedResult.csvnew+11 −0
- typo3/sysext/backend/Tests/Functional/Backend/Fixtures/ShortcutsBase.csvnew+8 −0
- typo3/sysext/backend/Tests/Functional/Backend/Shortcut/ShortcutRepositoryTest.phpnew+181 −0
- typo3/sysext/backend/Tests/Functional/Controller/ShortcutControllerTest.phpnew+105 −0
- typo3/sysext/backend/Tests/Functional/Fixtures/sys_be_shortcuts.xmlnew+9 −0
- typo3/sysext/backend/Tests/Functional/Template/Components/Buttons/Action/ShortcutButtonTest.phpnew+122 −0
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordList.htmlnew+10 −0
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListSingleTable.htmlnew+10 −0
Show 29 more files
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifier.htmlnew+10 −0
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifierWithArguments.htmlnew+10 −0
- typo3/sysext/beuser/Classes/Controller/PermissionController.php+1 −2
- typo3/sysext/beuser/Resources/Private/Layouts/Default.html+1 −1
- typo3/sysext/core/Documentation/Changelog/master/Breaking-93093-ReworkShortcutPHPAPI.rstnew+131 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-92132-DeprecatedShortcutPHPAPI.rst+14 −8
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-93060-ShortcutTitleMustBeSetByControllers.rst+2 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-93093-DeprecateMethodNameInShortcutPHPAPI.rstnew+67 −0
- typo3/sysext/core/ext_tables.sql1+2 −2
- typo3/sysext/filelist/Classes/Controller/FileListController.php+1 −1
- typo3/sysext/form/Classes/Controller/FormManagerController.php+1 −3
- typo3/sysext/info/Classes/Controller/InfoModuleController.php+1 −1
- typo3/sysext/install/Classes/Updates/ShortcutRecordsMigration.phpnew+191 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+14 −0
- typo3/sysext/install/Tests/Functional/Updates/Fixtures/ShortcutsBase.csvnew+24 −0
- typo3/sysext/install/Tests/Functional/Updates/Fixtures/ShortcutsMigratedToRoutes.csvnew+24 −0
- typo3/sysext/install/Tests/Functional/Updates/ShortcutRecordsMigrationTest.phpnew+75 −0
- typo3/sysext/install/ext_localconf.php+2 −0
- typo3/sysext/lowlevel/Classes/Controller/ConfigurationController.php+2 −1
- typo3/sysext/lowlevel/Classes/Controller/DatabaseIntegrityController.php+1 −1
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+1 −1
- typo3/sysext/recycler/Classes/Controller/RecyclerModuleController.php+1 −1
- typo3/sysext/redirects/Classes/Controller/ManagementController.php+1 −1
- typo3/sysext/reports/Classes/Controller/ReportController.php+1 −1
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+1 −1
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+1 −1
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php+1 −1
- typo3/sysext/viewpage/Classes/Controller/ViewModuleController.php+1 −1
- typo3/sysext/workspaces/Classes/Controller/ReviewController.php+1 −1
Review log 2440
Show 815 earlier messages
-
Oli Bartsch uploaded patch set 1 12/15/20, 16:02
-
Oli Bartsch updated the commit message in patch set 2 12/15/20, 16:02
-
TYPO3com voted on patch set 1 V -1 12/15/20, 16:12 Completed build in 09m 48s on Tue, 15 Dec, 04:12 PM Test Summary: 1 of 32653 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8202
-
TYPO3com voted on patch set 2 V -1 12/15/20, 16:17 Completed build in 11m 14s on Tue, 15 Dec, 04:17 PM Test Summary: 1 of 32653 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8203
-
Oli Bartsch uploaded patch set 3 12/15/20, 23:50
-
TYPO3com voted on patch set 3 V -1 12/16/20, 00:01 Completed build in 10m 23s on Wed, 16 Dec, 12:01 AM Test Summary: 11 of 32701 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8208
-
Oli Bartsch uploaded patch set 4 12/16/20, 00:02
-
Oli Bartsch uploaded patch set 5 12/16/20, 00:09
-
TYPO3com voted on patch set 4 V -1 12/16/20, 00:14 Completed build in 11m 19s on Wed, 16 Dec, 12:14 AM Test Summary: 1 of 32701 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8209
-
TYPO3com voted on patch set 5 V +1 12/16/20, 00:21 Completed build in 11m 39s on Wed, 16 Dec, 12:21 AM Test Summary: 32460 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8210
-
Oli Bartsch uploaded patch set 6 12/16/20, 12:37
-
TYPO3com voted on patch set 6 V -1 12/16/20, 12:48 Completed build in 10m 58s on Wed, 16 Dec, 12:48 PM Test Summary: 2 of 32719 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8212
-
Oli Bartsch uploaded patch set 7 12/16/20, 13:02
-
TYPO3com voted on patch set 7 V -1 12/16/20, 13:12 Completed build in 09m 38s on Wed, 16 Dec, 01:12 PM Test Summary: 32478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8213
-
Oli Bartsch uploaded patch set 8 12/16/20, 13:21
-
TYPO3com voted on patch set 8 V +1 12/16/20, 13:30 Completed build in 09m 21s on Wed, 16 Dec, 01:30 PM Test Summary: 32478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8214
-
Oli Bartsch uploaded patch set 9 12/16/20, 14:11
-
TYPO3com voted on patch set 9 V +1 12/16/20, 14:19 Completed build in 08m 34s on Wed, 16 Dec, 02:19 PM Test Summary: 32478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8215
-
Oli Bartsch uploaded patch set 10 12/16/20, 14:59
-
TYPO3com voted on patch set 10 V +1 12/16/20, 15:08 Completed build in 09m 32s on Wed, 16 Dec, 03:08 PM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8216
-
Oli Bartsch uploaded patch set 11 12/16/20, 17:54
-
TYPO3com voted on patch set 11 V +1 12/16/20, 18:04 Completed build in 09m 37s on Wed, 16 Dec, 06:04 PM Test Summary: 32494 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8217
-
Oli Bartsch uploaded patch set 12 12/16/20, 22:57
-
TYPO3com voted on patch set 12 V +1 12/16/20, 23:06 Completed build in 08m 27s on Wed, 16 Dec, 11:06 PM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8219
-
Oli Bartsch updated the commit message in patch set 13 12/16/20, 23:12
-
TYPO3com voted on patch set 13 V +1 12/16/20, 23:22 Completed build in 10m 08s on Wed, 16 Dec, 11:22 PM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8220
-
Daniel Goerz commented on patch set 13 12/17/20, 08:30
-
Oli Bartsch uploaded patch set 14 12/17/20, 10:14
-
Oli Bartsch commented on patch set 14 12/17/20, 10:14
ShortcutRepository.php:79ReplyDone -
TYPO3com voted on patch set 14 V +1 12/17/20, 10:23 Completed build in 09m 00s on Thu, 17 Dec, 10:23 AM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8223
-
Christian Kuhn commented on patch set 14 12/17/20, 11:24
ext_tables.sql:136Unresolvedabove 2 cols are obsolete now, right? -
Christian Kuhn voted on patch set 14 CR -1 12/17/20, 11:52
-
Oli Bartsch uploaded patch set 15 12/17/20, 13:06
-
TYPO3com voted on patch set 15 V -1 12/17/20, 13:16 Completed build in 09m 15s on Thu, 17 Dec, 01:16 PM Test Summary: 18 of 32737 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8227
-
Oli Bartsch uploaded patch set 16 12/17/20, 13:28
-
TYPO3com voted on patch set 16 V +1 12/17/20, 13:38 Completed build in 09m 28s on Thu, 17 Dec, 01:38 PM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8229
-
Daniel Goerz voted on patch set 16 V +1 CR +1 12/17/20, 13:42
-
Christian Kuhn voted on patch set 16 V +1 CR +1 12/17/20, 13:43
-
Christian Kuhn voted on patch set 16 V +2 CR +2 12/17/20, 13:53
-
Christian Kuhn merged patch set 17 12/17/20, 13:53
ShortcutRepository.php:79