Review main Merged Breaking

67143[!!!][TASK] Rework shortcut PHP API functionality

Oli Bartsch CR +2 V +2 Expert +1444 −337 updated 12/17/20, 13:53

Commit message

To be able to introduce URL rewrites for the backend,
the internal handling and registration of the shortcut
PHP API is reworked.

The Shortcut PHP API previously has the full URL of
the shortcut target stored in the database. This lead
to many problems such as shortcuts got invalid as soon
as their target module changed its route path. Furthermore,
this required unnecessary functionality like replacing
tokens on URL creation.

Therefore, a shortcut record now stores only the route
identifier of the module to link to and necessary arguments
in two new database columns. A upgrade wizard is in place
to migrate existing data.

The rework also required to deprecate some methods in
the ShortcutButton API and a parameter signature change
of the JavaScript function `TYPO3.ShortcutMenu.createShortcut()`
which performs the AJAX call to create new shortcuts.

Side effect, this also deprecated the last remains of
xMOD_alt_doc.php in the core.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 49

Show 29 more files

Review log 2440

Show 815 earlier messages
  1. Oli Bartsch uploaded patch set 1 12/15/20, 16:02

  2. Oli Bartsch updated the commit message in patch set 2 12/15/20, 16:02

  3. TYPO3com voted on patch set 1 V -1 12/15/20, 16:12 Completed build in 09m 48s on Tue, 15 Dec, 04:12 PM Test Summary: 1 of 32653 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8202

  4. TYPO3com voted on patch set 2 V -1 12/15/20, 16:17 Completed build in 11m 14s on Tue, 15 Dec, 04:17 PM Test Summary: 1 of 32653 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8203

  5. Oli Bartsch uploaded patch set 3 12/15/20, 23:50

  6. TYPO3com voted on patch set 3 V -1 12/16/20, 00:01 Completed build in 10m 23s on Wed, 16 Dec, 12:01 AM Test Summary: 11 of 32701 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8208

  7. Oli Bartsch uploaded patch set 4 12/16/20, 00:02

  8. Oli Bartsch uploaded patch set 5 12/16/20, 00:09

  9. TYPO3com voted on patch set 4 V -1 12/16/20, 00:14 Completed build in 11m 19s on Wed, 16 Dec, 12:14 AM Test Summary: 1 of 32701 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8209

  10. TYPO3com voted on patch set 5 V +1 12/16/20, 00:21 Completed build in 11m 39s on Wed, 16 Dec, 12:21 AM Test Summary: 32460 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8210

  11. Oli Bartsch uploaded patch set 6 12/16/20, 12:37

  12. TYPO3com voted on patch set 6 V -1 12/16/20, 12:48 Completed build in 10m 58s on Wed, 16 Dec, 12:48 PM Test Summary: 2 of 32719 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8212

  13. Oli Bartsch uploaded patch set 7 12/16/20, 13:02

  14. TYPO3com voted on patch set 7 V -1 12/16/20, 13:12 Completed build in 09m 38s on Wed, 16 Dec, 01:12 PM Test Summary: 32478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8213

  15. Oli Bartsch uploaded patch set 8 12/16/20, 13:21

  1. TYPO3com voted on patch set 8 V +1 12/16/20, 13:30 Completed build in 09m 21s on Wed, 16 Dec, 01:30 PM Test Summary: 32478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8214

  2. Oli Bartsch uploaded patch set 9 12/16/20, 14:11

  3. TYPO3com voted on patch set 9 V +1 12/16/20, 14:19 Completed build in 08m 34s on Wed, 16 Dec, 02:19 PM Test Summary: 32478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8215

  4. Oli Bartsch uploaded patch set 10 12/16/20, 14:59

  5. TYPO3com voted on patch set 10 V +1 12/16/20, 15:08 Completed build in 09m 32s on Wed, 16 Dec, 03:08 PM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8216

  6. Oli Bartsch uploaded patch set 11 12/16/20, 17:54

  7. TYPO3com voted on patch set 11 V +1 12/16/20, 18:04 Completed build in 09m 37s on Wed, 16 Dec, 06:04 PM Test Summary: 32494 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8217

  8. Oli Bartsch uploaded patch set 12 12/16/20, 22:57

  9. TYPO3com voted on patch set 12 V +1 12/16/20, 23:06 Completed build in 08m 27s on Wed, 16 Dec, 11:06 PM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8219

  10. Oli Bartsch updated the commit message in patch set 13 12/16/20, 23:12

  11. TYPO3com voted on patch set 13 V +1 12/16/20, 23:22 Completed build in 10m 08s on Wed, 16 Dec, 11:22 PM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8220

  12. Daniel Goerz commented on patch set 13 12/17/20, 08:30

    ShortcutRepository.php:79

    Would suggest to switch to DI here, esp. since we are introducing a new class dependency
  13. Oli Bartsch uploaded patch set 14 12/17/20, 10:14

  14. Oli Bartsch commented on patch set 14 12/17/20, 10:14

    ShortcutRepository.php:79 Reply

    Done
  15. TYPO3com voted on patch set 14 V +1 12/17/20, 10:23 Completed build in 09m 00s on Thu, 17 Dec, 10:23 AM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8223

  16. Christian Kuhn commented on patch set 14 12/17/20, 11:24

    ext_tables.sql:136 Unresolved

    above 2 cols are obsolete now, right?
  17. Christian Kuhn voted on patch set 14 CR -1 12/17/20, 11:52

  18. Oli Bartsch uploaded patch set 15 12/17/20, 13:06

  19. TYPO3com voted on patch set 15 V -1 12/17/20, 13:16 Completed build in 09m 15s on Thu, 17 Dec, 01:16 PM Test Summary: 18 of 32737 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8227

  20. Oli Bartsch uploaded patch set 16 12/17/20, 13:28

  21. TYPO3com voted on patch set 16 V +1 12/17/20, 13:38 Completed build in 09m 28s on Thu, 17 Dec, 01:38 PM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8229

  22. Daniel Goerz voted on patch set 16 V +1 CR +1 12/17/20, 13:42

  23. Christian Kuhn voted on patch set 16 V +1 CR +1 12/17/20, 13:43

  24. Christian Kuhn voted on patch set 16 V +2 CR +2 12/17/20, 13:53

  25. Christian Kuhn merged patch set 17 12/17/20, 13:53