Review main Abandoned

67176[BUGFIX] Fix unnecessary cHash when using extbase RouteEnhancer

Kevin Ditscheid CR 0 V 0 Easy +5 −4 updated 10/20/21, 11:33

Commit message

This commit fixes the unnecessary addition of a cHash if the ExtbasePluginEnhancer
is used to map URL parameters. It lets the inflateParameters function return before
setting namespace parameters

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 46

  1. Kevin Ditscheid uploaded patch set 1 12/17/20, 15:11

  2. TYPO3com voted on patch set 1 V -1 12/17/20, 15:20 Completed build in 09m 23s on Thu, 17 Dec, 03:20 PM Test Summary: 99 of 32737 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8231

  3. Benni Mack rebased onto patch set 2 10/08/21, 07:58

  4. core-ci voted on patch set 2 V -1 10/08/21, 08:27 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17796

  5. Oliver Hader commented on patch set 2 V -1 10/20/21, 09:34

    Please see my comments at https://forge.typo3.org/issues/93100#note-7 - I guess a custom aspect mapper might be better (in case I understood the use-case correctly). This change * breaks nested Extbase arguments @tx_testing_link[any][other]@ (will be @tx_testing_link__any__other@ with this change) * (probably) does not consider controller-action defaults anymore * does not properly address the @cHash@ topic - which is actually handled in @PageRouter@, not in enhancers
  6. Oliver Hader abandoned the change 10/20/21, 11:33

    See Forge ticket... in case changes are still/really required, this change-set can be restored.