Review main Merged Breaking

67177[!!!][TASK] Rework user group fetching for frontend users

Benni Mack CR +2 V +2 Hard +163 −209 updated 12/18/20, 23:22

Commit message

This change adapts the frontend user resolving to use
the same functionality as in backend users, which wasn't
the case in the past 15 years.

The newly introduced GroupResolver now also resolves
groups for frontend users recursively, making the "getGroupsFE"
and "authGroupsFE" functionality obsolete.

The AuthenticationService->getGroups methods are removed,
also the properties userTS, userData_change and TSdataArray have
been made protected, as it is only used for internal purposes.

The "userTSUpdated" flag has been removed and the property $TSdataArray
has been marked as internal.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 15

Review log 3444

Show 1319 earlier messages
  1. Benni Mack uploaded patch set 1 12/17/20, 22:34

  2. TYPO3com voted on patch set 1 V -1 12/17/20, 22:45 Completed build in 11m 11s on Thu, 17 Dec, 10:45 PM Test Summary: 271 of 32737 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8235

  3. Benni Mack uploaded patch set 2 12/18/20, 10:58

  4. TYPO3com voted on patch set 2 V -1 12/18/20, 11:06 Completed build in 08m 29s on Fri, 18 Dec, 11:06 AM Test Summary: 10 of 32737 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8245

  5. Benni Mack uploaded patch set 3 12/18/20, 11:50

  6. TYPO3com voted on patch set 3 V +1 12/18/20, 11:58 Completed build in 08m 00s on Fri, 18 Dec, 11:58 AM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8247

  7. Benni Mack updated the commit message in patch set 4 12/18/20, 14:13

  8. TYPO3com voted on patch set 4 V +1 12/18/20, 14:22 Completed build in 08m 46s on Fri, 18 Dec, 02:22 PM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8254

  9. Benni Mack uploaded patch set 5 12/18/20, 15:26

  10. TYPO3com voted on patch set 5 V +1 12/18/20, 15:35 Completed build in 09m 07s on Fri, 18 Dec, 03:35 PM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8255

  11. Oliver Klee commented on patch set 5 12/18/20, 16:08

    FrontendUserAuthentication.php:123 Unresolved

    Can't we move this to the shared base class? Then we could also simplify the instanceof checks to only check for the base class, not ||ing the checks for the subclasses.
  12. Georg Ringer uploaded patch set 6 12/18/20, 17:54

  13. Georg Ringer voted on patch set 6 V +1 CR +1 12/18/20, 17:55

  14. TYPO3com voted on patch set 6 V +1 12/18/20, 18:04 Completed build in 10m 16s on Fri, 18 Dec, 06:04 PM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8260

  15. Richard Haeser voted on patch set 6 CR +1 12/18/20, 18:10

  16. Richard Haeser commented on patch set 6 V +1 12/18/20, 18:15

    As far as I can see everything works fine. But as I don't have a really extended frontend-user setup, maybe someone else can do another check.
  17. Oli Bartsch voted on patch set 6 V +1 CR +1 12/18/20, 18:19

  18. Oliver Klee commented on patch set 6 12/18/20, 18:21

    @Benni: Can you say something concerning my question?
  19. Benni Mack commented on patch set 6 12/18/20, 18:40

    will incorporate Oli's suggestion (good one)
  1. Benni Mack uploaded patch set 7 12/18/20, 18:42

  2. Oliver Klee commented on patch set 7 12/18/20, 18:49

    UserAspect.php:167 Unresolved

    Then we can simplify this to instanceof AbstractUserAuthentication.
  3. Richard Haeser commented on patch set 7 12/18/20, 18:50

    UserAspect.php:167

    Shouldn't we check on the abstract here? Or is there a reason to only check for those two?
  4. Richard Haeser commented on patch set 7 12/18/20, 18:50

    UserAspect.php:167 Reply

    Ah, same as Oliver
  5. TYPO3com voted on patch set 7 V +1 12/18/20, 18:52 Completed build in 09m 28s on Fri, 18 Dec, 06:52 PM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8263

  6. Benni Mack uploaded patch set 8 12/18/20, 18:58

  7. Richard Haeser voted on patch set 8 V +1 CR +1 12/18/20, 19:12

  8. TYPO3com voted on patch set 8 V +1 12/18/20, 19:13 Completed build in 12m 24s on Fri, 18 Dec, 07:13 PM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8267

  9. Oliver Klee commented on patch set 8 12/18/20, 19:19

    UserAspect.php:39

    If we take the pseudo-user into account, this needs to be AbstractUserAuthentication|\stdClass, I think. (Otherwise, the instanceof check in line 167 would not be necessary anymore.)
  10. Benni Mack commented on patch set 8 12/18/20, 20:03

    UserAspect.php:39 Reply

    I agree with you, but is this part of the scope? I mean, ideally we wouldn't use stdClass then, and come up with an empty AbstractUserAuthentication (like a "DummyUserAuthentication") which contains only the functionality needed for this class, I'd say?
  11. Oliver Klee commented on patch set 8 12/18/20, 20:19

    UserAspect.php:39 Reply

    I would also be okay with moving this to another changeset. I have no idea how this will affect PHPStan, though.
  12. Benni Mack commented on patch set 8 12/18/20, 20:22

    UserAspect.php:39 Reply

    I guess I don't understand: What do you mean with "how this will affect PHPStan?"
  13. Oliver Klee commented on patch set 8 12/18/20, 20:35

    UserAspect.php:39 Reply Unresolved

    PHPStan might complain that the instanceof check is redundant if the field is annotated to be an instance of the respective class only (an nothing else).
  14. Andreas Kienast commented on patch set 8 CR -1 12/18/20, 21:21

    on it
  15. Andreas Kienast uploaded patch set 9 12/18/20, 21:42

  16. TYPO3com voted on patch set 9 V +1 12/18/20, 21:53 Completed build in 10m 22s on Fri, 18 Dec, 09:52 PM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8275

  17. Andreas Kienast uploaded patch set 10 12/18/20, 21:57

  18. Andreas Kienast voted on patch set 10 V +1 CR +1 12/18/20, 21:57

  19. TYPO3com voted on patch set 10 V +1 12/18/20, 22:09 Completed build in 11m 57s on Fri, 18 Dec, 10:09 PM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8278

  20. Christian Kuhn commented on patch set 10 V +1 CR +1 12/18/20, 22:39

    perfect. wante
  21. Oliver Hader voted on patch set 10 CR +1 12/18/20, 23:08

  22. Oli Bartsch voted on patch set 10 V +1 CR +1 12/18/20, 23:11

  23. Oliver Hader voted on patch set 10 V +1 12/18/20, 23:20

  24. Oliver Hader voted on patch set 10 V +2 CR +2 12/18/20, 23:20

  25. Oliver Hader merged patch set 11 12/18/20, 23:22