67177[!!!][TASK] Rework user group fetching for frontend users
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Oli Bartsch +1
- Christian Kuhn +1
- Andreas Kienast +1
-
Verified V +2 Done
- Oliver Hader +2
- Oli Bartsch +1
- Christian Kuhn +1
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 15
- typo3/sysext/core/Classes/Authentication/AbstractAuthenticationService.php+0 −8
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php+5 −2
- typo3/sysext/core/Classes/Authentication/AuthenticationService.php+0 −101
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+0 −6
- typo3/sysext/core/Classes/Context/UserAspect.php8+3 −6
- typo3/sysext/core/Documentation/Changelog/master/Breaking-93108-ReworkedInternalUserGroupFetchingForFrontendUsers.rstnew+68 −0
- typo3/sysext/core/Tests/Unit/Context/UserAspectTest.php+6 −4
- typo3/sysext/core/ext_localconf.php+1 −1
- typo3/sysext/felogin/Classes/Redirect/RedirectModeHandler.php+3 −3
- typo3/sysext/felogin/Classes/Service/UserService.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Security/IfHasRoleViewHelperTest.php+3 −3
- typo3/sysext/frontend/Classes/Authentication/FrontendUserAuthentication.php1+31 −73
- typo3/sysext/frontend/Tests/Functional/Configuration/TypoScript/ConditionMatching/ConditionMatcherTest.php+3 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+14 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php+25 −0
Review log 3444
Show 1319 earlier messages
-
Benni Mack uploaded patch set 1 12/17/20, 22:34
-
TYPO3com voted on patch set 1 V -1 12/17/20, 22:45 Completed build in 11m 11s on Thu, 17 Dec, 10:45 PM Test Summary: 271 of 32737 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8235
-
Benni Mack uploaded patch set 2 12/18/20, 10:58
-
TYPO3com voted on patch set 2 V -1 12/18/20, 11:06 Completed build in 08m 29s on Fri, 18 Dec, 11:06 AM Test Summary: 10 of 32737 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8245
-
Benni Mack uploaded patch set 3 12/18/20, 11:50
-
TYPO3com voted on patch set 3 V +1 12/18/20, 11:58 Completed build in 08m 00s on Fri, 18 Dec, 11:58 AM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8247
-
Benni Mack updated the commit message in patch set 4 12/18/20, 14:13
-
TYPO3com voted on patch set 4 V +1 12/18/20, 14:22 Completed build in 08m 46s on Fri, 18 Dec, 02:22 PM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8254
-
Benni Mack uploaded patch set 5 12/18/20, 15:26
-
TYPO3com voted on patch set 5 V +1 12/18/20, 15:35 Completed build in 09m 07s on Fri, 18 Dec, 03:35 PM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8255
-
Oliver Klee commented on patch set 5 12/18/20, 16:08
-
Georg Ringer uploaded patch set 6 12/18/20, 17:54
-
Georg Ringer voted on patch set 6 V +1 CR +1 12/18/20, 17:55
-
TYPO3com voted on patch set 6 V +1 12/18/20, 18:04 Completed build in 10m 16s on Fri, 18 Dec, 06:04 PM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8260
-
Richard Haeser voted on patch set 6 CR +1 12/18/20, 18:10
-
Richard Haeser commented on patch set 6 V +1 12/18/20, 18:15
As far as I can see everything works fine. But as I don't have a really extended frontend-user setup, maybe someone else can do another check. -
Oli Bartsch voted on patch set 6 V +1 CR +1 12/18/20, 18:19
-
Oliver Klee commented on patch set 6 12/18/20, 18:21
@Benni: Can you say something concerning my question? -
Benni Mack commented on patch set 6 12/18/20, 18:40
will incorporate Oli's suggestion (good one)
-
Benni Mack uploaded patch set 7 12/18/20, 18:42
-
Oliver Klee commented on patch set 7 12/18/20, 18:49
UserAspect.php:167UnresolvedThen we can simplify this to instanceof AbstractUserAuthentication. -
Richard Haeser commented on patch set 7 12/18/20, 18:50
UserAspect.php:167Shouldn't we check on the abstract here? Or is there a reason to only check for those two? -
Richard Haeser commented on patch set 7 12/18/20, 18:50
UserAspect.php:167ReplyAh, same as Oliver -
TYPO3com voted on patch set 7 V +1 12/18/20, 18:52 Completed build in 09m 28s on Fri, 18 Dec, 06:52 PM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8263
-
Benni Mack uploaded patch set 8 12/18/20, 18:58
-
Richard Haeser voted on patch set 8 V +1 CR +1 12/18/20, 19:12
-
TYPO3com voted on patch set 8 V +1 12/18/20, 19:13 Completed build in 12m 24s on Fri, 18 Dec, 07:13 PM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8267
-
Oliver Klee commented on patch set 8 12/18/20, 19:19
UserAspect.php:39If we take the pseudo-user into account, this needs to be AbstractUserAuthentication|\stdClass, I think. (Otherwise, the instanceof check in line 167 would not be necessary anymore.) -
Benni Mack commented on patch set 8 12/18/20, 20:03
UserAspect.php:39ReplyI agree with you, but is this part of the scope? I mean, ideally we wouldn't use stdClass then, and come up with an empty AbstractUserAuthentication (like a "DummyUserAuthentication") which contains only the functionality needed for this class, I'd say? -
Oliver Klee commented on patch set 8 12/18/20, 20:19
UserAspect.php:39ReplyI would also be okay with moving this to another changeset. I have no idea how this will affect PHPStan, though. -
Benni Mack commented on patch set 8 12/18/20, 20:22
UserAspect.php:39ReplyI guess I don't understand: What do you mean with "how this will affect PHPStan?" -
Oliver Klee commented on patch set 8 12/18/20, 20:35
UserAspect.php:39Reply UnresolvedPHPStan might complain that the instanceof check is redundant if the field is annotated to be an instance of the respective class only (an nothing else). -
Andreas Kienast commented on patch set 8 CR -1 12/18/20, 21:21
on it -
Andreas Kienast uploaded patch set 9 12/18/20, 21:42
-
TYPO3com voted on patch set 9 V +1 12/18/20, 21:53 Completed build in 10m 22s on Fri, 18 Dec, 09:52 PM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8275
-
Andreas Kienast uploaded patch set 10 12/18/20, 21:57
-
Andreas Kienast voted on patch set 10 V +1 CR +1 12/18/20, 21:57
-
TYPO3com voted on patch set 10 V +1 12/18/20, 22:09 Completed build in 11m 57s on Fri, 18 Dec, 10:09 PM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8278
-
Christian Kuhn commented on patch set 10 V +1 CR +1 12/18/20, 22:39
perfect. wante -
Oliver Hader voted on patch set 10 CR +1 12/18/20, 23:08
-
Oli Bartsch voted on patch set 10 V +1 CR +1 12/18/20, 23:11
-
Oliver Hader voted on patch set 10 V +1 12/18/20, 23:20
-
Oliver Hader voted on patch set 10 V +2 CR +2 12/18/20, 23:20
-
Oliver Hader merged patch set 11 12/18/20, 23:22
FrontendUserAuthentication.php:123Unresolved