Review main Merged

67178[TASK] Migrate backend live search to use lit-html for templating

Oliver Hader CR +2 V +2 Normal +43 −23 updated 04/07/21, 20:09

Commit message

Migrates backend UI component `LiveSearch` to be based on `lit-html`.
In order to avoid string based concatenation which relies on the
server side to properly escape html – which might not always
work, when HTML is used in different contexts (node vs attributes).

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benni Mack +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 3

Review log 915

  1. Oliver Hader uploaded patch set 1 12/17/20, 23:05

  2. TYPO3com voted on patch set 1 V -1 12/17/20, 23:19 Completed build in 13m 34s on Thu, 17 Dec, 11:19 PM Test Summary: 77 of 32737 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8237

  3. Oliver Hader rebased onto patch set 2 12/18/20, 00:03

  4. TYPO3com commented on patch set 2 12/18/20, 00:17 Completed build in 13m 37s on Fri, 18 Dec, 12:17 AM Test Summary: 12 of 31192 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8240

  5. TYPO3com voted on patch set 2 V +1 12/18/20, 08:05 Completed build in 09m 49s on Fri, 18 Dec, 08:05 AM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8243

  6. Benjamin Franzke uploaded patch set 3 12/21/20, 15:19

  7. TYPO3com voted on patch set 3 V +1 12/21/20, 15:39 Completed build in 15m 37s on Mon, 21 Dec, 03:39 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8379

  8. Benjamin Franzke wrote 12/22/20, 08:42

    Topic set to lit
  9. Benni Mack voted on patch set 3 CR +1 04/07/21, 19:32

  10. Benni Mack rebased onto patch set 4 04/07/21, 19:32

  11. TYPO3com voted on patch set 4 V +1 04/07/21, 19:39 Completed build in 06m 37s on Wed, 7 Apr, 07:39 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10527

  12. core-ci voted on patch set 4 V +1 04/07/21, 19:43 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2081

  13. Benni Mack voted on patch set 4 V +1 CR +1 04/07/21, 19:59

  14. Oliver Hader voted on patch set 4 V +2 CR +2 04/07/21, 20:09

  15. Oliver Hader merged patch set 5 04/07/21, 20:09