67180[WIP][TASK] Migrate backend context menu to lit-html
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 9
- Build/Sources/Sass/typo3/_element_contextmenu.scss+2 −59
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ContextMenu.ts+351 −230
- Build/Sources/TypeScript/core/Resources/Public/TypeScript/lit-helper.ts+113 −2
- typo3/sysext/backend/Classes/ContextMenu/ItemProviders/AbstractProvider.php+3 −2
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ContextMenu.js+87 −1
- typo3/sysext/core/Resources/Public/JavaScript/lit-helper.js+1 −1
- typo3/sysext/core/Tests/Acceptance/Backend/PageTree/PageTreeFilterCest.php+1 −1
- .stylelintrc+6 −7
Review log 2039
Show 714 earlier messages
-
Oliver Hader uploaded patch set 1 12/17/20, 23:12
-
Oliver Hader commented on patch set 1 12/17/20, 23:14
WIP since event handling with context menu seems to be flaky - most probably due to the mixture of lit-html and (arbitrary) jQuery events. The current misbehavior can be reproduced by e.g. * opening context menu in page-tree for any (standard) page * select `info` menu item action * closing information modal reveals, that actually more than one instances were created -
TYPO3com voted on patch set 1 V -1 12/17/20, 23:20 Completed build in 08m 28s on Thu, 17 Dec, 11:20 PM Test Summary: 35 of 10436 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8239
-
TYPO3com voted on patch set 1 V +1 12/18/20, 12:09 Completed build in 08m 43s on Fri, 18 Dec, 12:09 PM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8248
-
Benjamin Franzke wrote 12/22/20, 10:01
Topic set to lit -
Benjamin Franzke uploaded patch set 2 01/12/21, 22:32
-
Benjamin Franzke commented on patch set 2 CR -2 01/12/21, 22:35
Reply
Yes, thank you, the events were registered over and over again, because lit-html used to reuse HTML elements. While this would be easy to fix I realized it would be better to properly migrate this entirely to LitElement and not do this mixed approach. Threfore I've pushed my current state to document, why this keeps to be WIP for now, because some preparations (IconHandling, descision regarding shadow dom, inline html/css minifier) need to be taken into account first. -
TYPO3com voted on patch set 2 V -1 01/12/21, 22:43 Completed build in 10m 32s on Tue, 12 Jan, 10:43 PM Test Summary: 1 of 32816 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8839
-
Benjamin Franzke uploaded patch set 3 02/08/21, 13:06
-
TYPO3com voted on patch set 3 V -1 02/08/21, 13:15 Completed build in 08m 35s on Mon, 8 Feb, 01:15 PM Test Summary: 1 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9348
-
core-ci voted on patch set 3 V -1 02/08/21, 13:19 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/478
-
Benjamin Franzke uploaded patch set 4 02/08/21, 23:51
-
TYPO3com voted on patch set 4 V +1 02/09/21, 00:00 Completed build in 09m 03s on Tue, 9 Feb, 12:00 AM Test Summary: 32587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9365
-
core-ci voted on patch set 4 V +1 02/09/21, 00:03 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/502
-
Benni Mack commented on patch set 4 02/09/21, 07:17
I wonder if we should move the IconElement out of this change first and get it in before continuing working on this change... -
Benjamin Franzke uploaded patch set 5 02/09/21, 10:00
-
Benjamin Franzke commented on patch set 5 02/09/21, 10:00
Reply
Yeah, definitely (see TODO "Move the new IconElement into a separate patch"), I used this patch as usecase for the IconElement and therefore kept developing it within this patch. As soon as it feels ready, I will split. -
TYPO3com voted on patch set 5 V -1 02/09/21, 10:09 Completed build in 09m 00s on Tue, 9 Feb, 10:09 AM Test Summary: 32587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9375
-
core-ci voted on patch set 5 V +1 02/09/21, 10:16 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/513
-
Benjamin Franzke uploaded patch set 6 02/09/21, 12:05
-
TYPO3com voted on patch set 6 V -1 02/09/21, 12:13 Completed build in 08m 25s on Tue, 9 Feb, 12:13 PM Test Summary: 86 of 32838 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9385
-
core-ci voted on patch set 6 V -1 02/09/21, 12:15 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/522
-
Benjamin Franzke uploaded patch set 7 02/09/21, 14:05
-
Benjamin Franzke commented on patch set 7 02/09/21, 14:05
IconElement.ts:31Moved into separate patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67675 -
TYPO3com voted on patch set 7 V -1 02/09/21, 14:06 Completed build in 17s on Tue, 9 Feb, 02:05 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9396
-
TYPO3com commented on patch set 7 02/09/21, 14:11 Completed build in 21s on Tue, 9 Feb, 02:11 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9398
-
core-ci voted on patch set 7 V +1 02/09/21, 14:15 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/534
-
Benjamin Franzke uploaded patch set 8 02/09/21, 21:07
-
TYPO3com voted on patch set 8 V -1 02/09/21, 21:07 Completed build in 21s on Tue, 9 Feb, 09:07 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9415
-
core-ci voted on patch set 8 V +1 02/09/21, 21:22 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/553
-
Benjamin Franzke uploaded patch set 9 02/23/21, 22:51
-
TYPO3com voted on patch set 9 V -1 02/23/21, 22:52 Completed build in 20s on Tue, 23 Feb, 10:52 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9684
-
core-ci voted on patch set 9 V +1 02/23/21, 23:02 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/933
-
Oliver Hader commented on patch set 9 11/18/21, 14:54
What shall we do with this change? -
Benni Mack wrote 11/29/21, 10:17
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 10 11/29/21, 14:08
-
core-ci voted on patch set 10 V -1 11/29/21, 18:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20105
-
Benni Mack wrote 12/02/21, 20:18
Removed cc Benni Mack. -
Oliver Hader abandoned the change 04/08/23, 09:42