Review main Merged

67184[BUGFIX] Do not try to access user session on CLI

Helmut Hummel CR +2 V +2 Easy +8 −0 updated 12/20/20, 20:33

Commit message

Since CommandLineUserAuthentication does not initialize
the session property (because session handling is not needed
on cli), a fatal error occurs, when calling the `writeLog`
because a potentially simulated user is checked by accessing
the session within this method.

Therefore this check is now overridden as well
in CommandLineUserAuthentication to always assume the
original (cli) user for logging.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Simon Gilli +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Helmut Hummel uploaded patch set 1 12/18/20, 18:54

  2. TYPO3com voted on patch set 1 V +1 12/18/20, 19:03 Completed build in 08m 55s on Fri, 18 Dec, 07:03 PM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8264

  3. Tomas Norre Mikkelsen commented on patch set 1 V +1 12/20/20, 13:32

    I cannot say if this is the proper solution or not, but I had the same issue with a cli call for the Crawler, and this solves is.
  4. Helmut Hummel uploaded patch set 2 12/20/20, 20:10

  5. Oliver Klee voted on patch set 2 CR +1 12/20/20, 20:15

  6. Simon Gilli voted on patch set 2 CR +1 12/20/20, 20:15

  7. TYPO3com voted on patch set 2 V +1 12/20/20, 20:19 Completed build in 09m 15s on Sun, 20 Dec, 08:19 PM Test Summary: 32528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8357

  8. Simon Gilli voted on patch set 2 V +1 12/20/20, 20:32

  9. Simon Gilli commented on patch set 2 12/20/20, 20:33

    Works fine, tested with the instructions at Slack in the LostFilesCommand.
  10. Christian Kuhn voted on patch set 2 V +2 CR +2 12/20/20, 20:33

  11. Christian Kuhn merged patch set 3 12/20/20, 20:33