Review main Merged

67185[TASK] Implement t3editor as custom web component

Benjamin Franzke CR +2 V +2 Hard +342 −161 updated 01/04/21, 15:04

Commit message

Remove jQuery dependency, avoid inline javascript and
encapsulate initialization into a web component.

Also use "codemirror" as import name, as that's
what the npm package name is, and will eventually
allow to make use of TypeScript typings.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 284

Show 264 more files

Review log 2037

Show 612 earlier messages
  1. Benjamin Franzke uploaded patch set 1 12/18/20, 21:44

  2. TYPO3com voted on patch set 1 V +1 12/18/20, 21:58 Completed build in 12m 15s on Fri, 18 Dec, 09:58 PM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8276

  3. Benjamin Franzke uploaded patch set 2 12/18/20, 23:00

  4. TYPO3com voted on patch set 2 V +1 12/18/20, 23:11 Completed build in 11m 11s on Fri, 18 Dec, 11:11 PM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8282

  5. Benjamin Franzke uploaded patch set 3 12/18/20, 23:31

  6. TYPO3com voted on patch set 3 V +1 12/18/20, 23:42 Completed build in 10m 58s on Fri, 18 Dec, 11:42 PM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8285

  7. Benjamin Franzke uploaded patch set 4 12/19/20, 06:26

  8. TYPO3com voted on patch set 4 V -1 12/19/20, 06:37 Completed build in 10m 49s on Sat, 19 Dec, 06:37 AM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8291

  9. Benjamin Franzke uploaded patch set 5 12/19/20, 06:48

  10. TYPO3com voted on patch set 5 V -1 12/19/20, 07:00 Completed build in 11m 51s on Sat, 19 Dec, 07:00 AM Test Summary: 30773 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8292

  11. Benjamin Franzke uploaded patch set 6 12/19/20, 07:13

  12. TYPO3com voted on patch set 6 V -1 12/19/20, 07:22 Completed build in 08m 56s on Sat, 19 Dec, 07:22 AM Test Summary: 1 of 32737 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8293

  1. Benjamin Franzke uploaded patch set 7 12/19/20, 07:32

  2. TYPO3com voted on patch set 7 V -1 12/19/20, 07:43 Completed build in 11m 40s on Sat, 19 Dec, 07:43 AM Test Summary: 32095 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8294

  3. Benjamin Franzke uploaded patch set 8 12/19/20, 09:30

  4. TYPO3com voted on patch set 8 V -1 12/19/20, 09:40 Completed build in 10m 39s on Sat, 19 Dec, 09:40 AM Test Summary: 1 of 32737 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8295

  5. TYPO3com voted on patch set 8 V +1 12/19/20, 10:15 Completed build in 09m 33s on Sat, 19 Dec, 10:15 AM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8296

  6. Benjamin Franzke uploaded patch set 9 12/20/20, 06:29

  7. TYPO3com voted on patch set 9 V +1 12/20/20, 06:40 Completed build in 10m 20s on Sun, 20 Dec, 06:40 AM Test Summary: 32528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8337

  8. Benjamin Franzke uploaded patch set 10 12/20/20, 14:00

  9. TYPO3com voted on patch set 10 V -1 12/20/20, 14:11 Completed build in 10m 36s on Sun, 20 Dec, 02:11 PM Test Summary: 1 of 32769 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8344

  10. TYPO3com voted on patch set 10 V +1 12/20/20, 14:52 Completed build in 10m 30s on Sun, 20 Dec, 02:52 PM Test Summary: 32528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8345

  11. Benjamin Franzke uploaded patch set 11 12/22/20, 09:56

  12. TYPO3com voted on patch set 11 V -1 12/22/20, 10:05 Completed build in 09m 25s on Tue, 22 Dec, 10:05 AM Test Summary: 1 of 32781 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8424

  13. Benjamin Franzke uploaded patch set 12 12/22/20, 10:15

  14. TYPO3com voted on patch set 12 V +1 12/22/20, 10:26 Completed build in 10m 41s on Tue, 22 Dec, 10:26 AM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8426

  15. Benjamin Franzke uploaded patch set 13 01/01/21, 16:43

  16. TYPO3com voted on patch set 13 V -1 01/01/21, 16:52 Completed build in 08m 52s on Fri, 1 Jan, 04:52 PM Test Summary: 1 of 32781 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8539

  17. TYPO3com voted on patch set 13 V +1 01/01/21, 17:41 Completed build in 10m 19s on Fri, 1 Jan, 05:41 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8542

  18. Benjamin Franzke uploaded patch set 14 01/02/21, 07:40

  19. TYPO3com voted on patch set 14 V +1 01/02/21, 07:51 Completed build in 10m 45s on Sat, 2 Jan, 07:51 AM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8546

  20. Benni Mack voted on patch set 14 V +1 CR +1 01/02/21, 13:00

  21. Oliver Hader commented on patch set 14 CR +1 01/04/21, 14:40

    CodeMirrorElement.ts:50

    This general slot is used for `<textarea>` then, correct?
  22. Benjamin Franzke commented on patch set 14 01/04/21, 14:46

    CodeMirrorElement.ts:50 Reply

    Yes, exactly
  23. Oliver Hader voted on patch set 14 V +2 CR +2 01/04/21, 15:03

  24. Oliver Hader commented on patch set 14 01/04/21, 15:04

    CodeMirrorElement.ts:50 Reply

    Done
  25. Oliver Hader merged patch set 15 01/04/21, 15:04