Review main Merged

67186[BUGFIX] Set applicationType in ResetPasswordCommand

Oli Bartsch CR +2 V +2 Easy +4 −1 updated 12/18/20, 23:41

Commit message

Since #92951 the PSR-7 request used in Core contains the
`applicationType` attribute. Because ResetPasswordCommand
creates its own "fake" request object, the new attribute must
also be added there, to prevent a RuntimeException.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 46

  1. Oli Bartsch uploaded patch set 1 12/18/20, 22:41

  2. Christian Kuhn commented on patch set 1 V +1 CR +1 12/18/20, 22:43

    good catch!
  3. TYPO3com voted on patch set 1 V -1 12/18/20, 22:52 Completed build in 10m 47s on Fri, 18 Dec, 10:52 PM Test Summary: 1 of 32737 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8280

  4. TYPO3com voted on patch set 1 V +1 12/18/20, 22:59 Completed build in 28m 37s on Fri, 18 Dec, 10:59 PM Test Summary: 32495 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8280

  5. Benni Mack voted on patch set 1 V +2 CR +2 12/18/20, 23:41

  6. Benni Mack merged patch set 2 12/18/20, 23:41