Review main Merged

67188[BUGFIX] SQL error in some MM workspaces discard scenarios

Christian Kuhn CR +2 V +2 Easy +0 −8 updated 12/20/20, 18:56

Commit message

Depending on SQL structure of an MM table, the recent fix for
issue #93064 can lead to query errors: It works with core
category relations but fails for instance with ext:news
'related news' relations. This is due to an assumption
about existence of field 'tablenames', which is bogus.
If needed, the according where restriction comes from TCA
MM_match_fields already, which is sufficient.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Sebastian Michaelsen +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Sebastian Michaelsen +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 69

  1. Christian Kuhn uploaded patch set 1 12/19/20, 10:33

  2. TYPO3com voted on patch set 1 V +1 12/19/20, 10:45 Completed build in 11m 48s on Sat, 19 Dec, 10:45 AM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8299

  3. Christian Kuhn updated the commit message in patch set 2 12/19/20, 10:49

  4. TYPO3com voted on patch set 2 V -1 12/19/20, 10:59 Completed build in 09m 48s on Sat, 19 Dec, 10:59 AM Test Summary: 1 of 32737 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8300

  5. TYPO3com voted on patch set 2 V +1 12/19/20, 11:06 Completed build in 26m 00s on Sat, 19 Dec, 11:06 AM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8300

  6. Oli Bartsch voted on patch set 2 V +1 CR +1 12/19/20, 14:11

  7. Sebastian Michaelsen voted on patch set 2 V +1 CR +1 12/20/20, 17:58

  8. Benni Mack voted on patch set 2 V +2 CR +2 12/20/20, 18:55

  9. Benni Mack merged patch set 3 12/20/20, 18:56