Review main Merged

67189[BUGFIX] Re-add missing t3editor panel label

Benjamin Franzke CR +2 V +2 Easy +6 −2 updated 12/19/20, 13:20

Commit message

The t3editor panel label was removed by accident in
https://review.typo3.org/c/Packages/TYPO3.CMS/+/66225
because it was passed via the invalid textarea alt attribute.

Re-add this label via data-codemirror-config attribute.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 2

Files 3

Review log 58

  1. Benjamin Franzke uploaded patch set 1 12/19/20, 11:14

  2. TYPO3com voted on patch set 1 V -1 12/19/20, 11:26 Completed build in 12m 16s on Sat, 19 Dec, 11:26 AM Test Summary: 11 of 32362 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8303

  3. TYPO3com voted on patch set 1 V +1 12/19/20, 11:43 Completed build in 09m 38s on Sat, 19 Dec, 11:43 AM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8304

  4. Benjamin Franzke uploaded patch set 2 12/19/20, 11:45

  5. TYPO3com voted on patch set 2 V +1 12/19/20, 11:55 Completed build in 09m 20s on Sat, 19 Dec, 11:55 AM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8305

  6. Oli Bartsch voted on patch set 2 V +1 CR +1 12/19/20, 11:58

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 12/19/20, 13:20

  8. Christian Kuhn merged patch set 3 12/19/20, 13:20