Review main Merged

67190[FEATURE] Add reset button for EXT:beuser module filter

Oli Bartsch CR +2 V +2 Easy +41 −2 updated 12/22/20, 08:35

Commit message

Since the EXT:beuser module filter contains of a couple of
filter options, which are not automatically reset on leaving the
module, because they are stored in the user uc, one had to
change every option manually to reset the whole filter.

Therefore, a new button is now introduced, which allows to
reset the whole filter at once.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Josef Glatz +1
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1620

  1. Oli Bartsch uploaded patch set 1 12/19/20, 14:03

  2. TYPO3com voted on patch set 1 V +1 12/19/20, 14:12 Completed build in 09m 06s on Sat, 19 Dec, 02:12 PM Test Summary: 32496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8309

  3. Riccardo De Contardi commented on patch set 1 V +1 12/19/20, 16:17

    verified on 11.0.0-dev (latest master)
  4. Josef Glatz commented on patch set 2 12/21/20, 09:27

    Published edit on patch set 1.
  5. Josef Glatz voted on patch set 2 V +1 CR +1 12/21/20, 09:27

  6. TYPO3com voted on patch set 2 V -1 12/21/20, 09:39 Completed build in 12m 00s on Mon, 21 Dec, 09:39 AM Test Summary: 1 of 32245 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8364

  7. TYPO3com voted on patch set 2 V +1 12/21/20, 11:37 Completed build in 10m 18s on Mon, 21 Dec, 11:37 AM Test Summary: 32528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8371

  8. Benjamin Franzke commented on patch set 2 CR -1 12/21/20, 12:59

    -1 because that button is too highlighted in constrast to the Filter button.

    Index.html:51

    Hm, because of accessibility this should be a button, not a link.

    Index.html:51

    btn-warning makes this looking more important that the actualy "Filter" button. I'd prefer a "Text button" – see https://material.io/components/buttons#anatomy But I guess we don't have that in backend css yet..

    Index.html:51

    it kinda is a destructive operation (although not security relevant), still, somehow preferable would be to send via method POST instead of GET here. As we're already inside form, we'd need to handle reset in the indexAction.
  9. Josef Glatz voted on patch set 2 V 0 CR 0 12/21/20, 12:59

  10. Oli Bartsch commented on patch set 2 12/21/20, 15:18

    Index.html:51 Reply

    The whole form is currently GET so changing the method of the whole form to POST? Only changing the method for the link is IMO not possible, is it? I actually tried to use the index action for the reset. This does however not really work out, since passing null for Demand is intended so indexAction can fetch the data from the users UC, see: if ($demand === null) { $demand = $this->moduleData->getDemand(); } else { $this->moduleData->setDemand($demand); } So what would be your suggestion for handling the reset in the index action?

    Index.html:51 Reply

    Not sure, in its current state an a-Tag should be correct, since it's a link to another target.

    Index.html:51 Reply

    Yes, agree. Maybe we should make the colors the same as in the redirects module to unify the look through these modules? Or use "primary" for filter and "default" for reset?
  11. Benjamin Franzke uploaded patch set 3 12/21/20, 15:52

  12. Benjamin Franzke commented on patch set 3 12/21/20, 15:52

    Index.html:51 Reply

    I've now added btn-outline-default, which pretty much ends up as a "Text Button".

    Index.html:51 Reply

    Hm, it's POST for me. I'd add a new action argument "operation", which is triggered by the reset button.

    Index.html:51 Reply

    Now changed to button in order sending an operation value.
  13. Oli Bartsch voted on patch set 3 V +1 CR +1 12/21/20, 15:57

  14. TYPO3com voted on patch set 3 V +1 12/21/20, 16:02 Completed build in 09m 58s on Mon, 21 Dec, 04:02 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8381

  15. Benjamin Franzke commented on patch set 3 CR -1 12/21/20, 16:34

    Still code-review +1, but going back to -1 as changelog has already been moved into 11.0 folder, and this one needs to go into 11.1
  16. Benjamin Franzke commented on patch set 3 12/21/20, 16:34

    what I mean: This one needs to wait until the 11.0 release is done. "master" folder is of course fine.
  17. Oli Bartsch commented on patch set 3 12/21/20, 17:32

    Reply

    Fully ack. Not necessary for 11.0
  18. Josef Glatz voted on patch set 3 V +1 12/21/20, 20:32

  19. Benjamin Franzke voted on patch set 3 V +2 CR +2 12/22/20, 08:35

  20. Benjamin Franzke merged patch set 4 12/22/20, 08:35