Review main Merged

67191[TASK] Make workspace delete a discard

Christian Kuhn CR +2 V +2 Normal +46 −10 updated 12/21/20, 18:27

Commit message

When deleting a record in workspaces that has been
changed in comparison to live - if it is a new, a moved
or a changed workspace record, those records where subject
to the 'soft-delete' strategy of the core: Soft-delete
enabled tables like pages or tt_content did set deleted=1
for those records instead of fully deleting them from the
table. The idea was to allow 'undelete' via recycler or
history module if those records have been deleted by
accident.

However, the undelete workspace records functionality
never worked and has never been fixed. The oldest open
forge issue on this topic is 11 (!) years old.

The solution is to discard those records instead of
soft-deleting them. This effectively drops soft-delete
for workspace records. It's done by a trivial switch in
the main DataHandler delete method to re-route workspace
delete operation to the recently refactored discard
methods instead.

This change allows us to further refactor the remaining
tasks the DataHandler delete functionality is concerned
with, since delete still handles three things:
* Deleting and soft-deleting records in live.
* Creating 'delete placeholder' records in workspaces.
  This is the 'mark the record as to-be-deleted in live
  on workspace publish' operation.
* Undeleting records using recycler and partially the
  history module.

Dropping the workspace-delete scenarios reduces complexity
significantly. The codebase can now be changed with upcoming
patches to separate remaining concerns - similar to what has
been done with discard already. The according scenarios will
see improved test coverage and far better understandable
code along the way. This will ultimately allow us to
fix remaining bugs in this area on one hand and to
improve user experience on the other hand.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Oli Bartsch +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 3

Files 10

Review log 1422

  1. Christian Kuhn uploaded patch set 1 12/19/20, 18:04

  2. TYPO3com voted on patch set 1 V -1 12/19/20, 18:14 Completed build in 09m 20s on Sat, 19 Dec, 06:14 PM Test Summary: 21 of 32769 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8321

  3. Christian Kuhn uploaded patch set 2 12/19/20, 19:03

  4. TYPO3com voted on patch set 2 V -1 12/19/20, 19:14 Completed build in 10m 39s on Sat, 19 Dec, 07:14 PM Test Summary: 9 of 32769 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8324

  5. Christian Kuhn uploaded patch set 3 12/20/20, 12:45

  6. Christian Kuhn updated the commit message in patch set 4 12/20/20, 12:49

  7. Christian Kuhn updated the commit message in patch set 5 12/20/20, 12:52

  8. TYPO3com voted on patch set 3 V +1 12/20/20, 12:56 Completed build in 10m 31s on Sun, 20 Dec, 12:56 PM Test Summary: 32528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8339

  9. Christian Kuhn updated the commit message in patch set 6 12/20/20, 12:56

  10. TYPO3com voted on patch set 4 V -1 12/20/20, 13:01 Completed build in 12m 07s on Sun, 20 Dec, 01:01 PM Test Summary: 1 of 32769 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8340

  11. TYPO3com voted on patch set 5 V +1 12/20/20, 13:04 Completed build in 10m 13s on Sun, 20 Dec, 01:04 PM Test Summary: 32528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8341

  12. TYPO3com voted on patch set 6 V -1 12/20/20, 13:09 Completed build in 10m 18s on Sun, 20 Dec, 01:09 PM Test Summary: 1 of 32769 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8342

  13. TYPO3com voted on patch set 6 V +1 12/20/20, 13:15 Completed build in 27m 06s on Sun, 20 Dec, 01:15 PM Test Summary: 32528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8342

  14. Benni Mack commented on patch set 6 CR -1 12/20/20, 19:51

    Releases line missing
  15. Christian Kuhn commented on patch set 6 12/20/20, 19:52

    Reply

    foo
  16. Christian Kuhn updated the commit message in patch set 7 12/20/20, 19:52

  17. TYPO3com voted on patch set 7 V +1 12/20/20, 20:02 Completed build in 09m 37s on Sun, 20 Dec, 08:02 PM Test Summary: 32528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8356

  18. Benni Mack voted on patch set 7 V +1 CR +1 12/21/20, 15:25

  19. Andreas Kienast voted on patch set 7 CR +1 12/21/20, 16:00

  20. Oli Bartsch voted on patch set 7 V +1 CR +1 12/21/20, 17:52

  21. Anja Leichsenring voted on patch set 7 V +2 CR +2 12/21/20, 18:26

  22. Anja Leichsenring merged patch set 8 12/21/20, 18:27