Review 10.4 Merged

67200[BUGFIX] Set timezone on TCA dbType input

Benjamin Franzke CR +2 V +2 Normal +73 −2 updated 12/21/20, 12:59

Commit message

The value from columns that are marked as "dbType" date(time) fields
in TCA configuration are now explicitly interpreted using UTC timezone,
when the string value has no timezone specifier given.
JS supplied values contain Z as specifier, while records from the database
(which are processed during copy operations) do not contain a timezone
specifier.
Local time was assumed by PHP in the latter case before, as we did not
pass an explicit timezone information to the DateTime constructor.

Therefore we now assure no timezone conversion will happen and no
time/date-offset will be added, by using UTC explicitly.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 34

  1. Benjamin Franzke commented on patch set 1 12/21/20, 12:44

    Cherry Picked from branch master.
  2. Benjamin Franzke voted on patch set 1 V +2 CR +2 12/21/20, 12:45

  3. TYPO3com voted on patch set 1 V +1 12/21/20, 12:56 Completed build in 12m 28s on Mon, 21 Dec, 12:56 PM Test Summary: 75274 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-929

  4. Benjamin Franzke merged patch set 2 12/21/20, 12:59