67212[CLEANUP] Fix PHPDoc type annotation for UserAspect::user
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 89
-
Oliver Klee uploaded patch set 1 12/20/20, 10:19
-
TYPO3com voted on patch set 1 V +1 12/20/20, 10:31 Completed build in 11m 51s on Sun, 20 Dec, 10:31 AM Test Summary: 32528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8338
-
Christian Kuhn voted on patch set 1 CR +1 12/20/20, 11:21
-
Oli Bartsch commented on patch set 1 12/20/20, 11:22
Technically this patch is fine. However, have you thought about Benni's comment in the other patch about introducing a DummyUserAuthentication instead of using stdClass here? -
Oliver Klee commented on patch set 1 12/20/20, 11:33
Reply
No, not yet. Thanks for bringing this up! After thinking about this, I think having this fix first and then updating the PHPDoc when the DummyUserAuthentication is introduced would we the proper way to proceed. -
Oliver Klee commented on patch set 1 12/20/20, 20:35
To avoid potential confusion after my previous message: I'd like to keep this change as is and have the change Benni suggested later in a separate change. -
Christian Kuhn commented on patch set 1 V +1 12/20/20, 20:43
fine with me. -
Benni Mack commented on patch set 1 V +2 CR +2 12/20/20, 20:50
Thanks, Oli, for providing the patch, and taking care. Highly appreciated! -
Benni Mack merged patch set 2 12/20/20, 20:50