67214[WIP][TASK] Deprecate record list event listeners in AjaxDataHandler
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 10
- Build/Sources/Sass/typo3/_element_animation.scss+18 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/AjaxDataHandler.ts1+10 −1
- Build/Sources/TypeScript/recordlist/Resources/Public/TypeScript/Element/DeleteRecordElement.ts6new+78 −0
- Build/Sources/TypeScript/recordlist/Resources/Public/TypeScript/Recordlist.ts+117 −4
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/AjaxDataHandler.js+1 −1
- typo3/sysext/recordlist/Classes/Controller/RecordListController.php+1 −0
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+14 −7
- typo3/sysext/recordlist/Resources/Public/JavaScript/Element/DeleteRecordElement.jsnew+13 −0
- typo3/sysext/recordlist/Resources/Public/JavaScript/Recordlist.js+1 −1
Review log 811
-
Andreas Kienast uploaded patch set 1 12/20/20, 15:49
-
Andreas Kienast updated the commit message in patch set 2 12/20/20, 15:50
-
Andreas Kienast commented on patch set 2 12/20/20, 15:52
-
TYPO3com voted on patch set 1 V +1 12/20/20, 16:00 Completed build in 10m 08s on Sun, 20 Dec, 04:00 PM Test Summary: 32528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8347
-
TYPO3com voted on patch set 2 V +1 12/20/20, 16:03 Completed build in 12m 59s on Sun, 20 Dec, 04:03 PM Test Summary: 32528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8348
-
Benjamin Franzke commented on patch set 2 12/20/20, 16:59
Unresolved
FYI, our bootstrap javascript is currently at alpha2, while css is beta1. I'm trying to tackle that in https://review.typo3.org/c/Packages/TYPO3.CMS/+/67215 So data-bs-* tags don't work yet, but still data-* – maybe that's what this todo is about? -
Andreas Kienast uploaded patch set 3 12/21/20, 09:37
-
TYPO3com voted on patch set 3 V +1 12/21/20, 09:48 Completed build in 11m 04s on Mon, 21 Dec, 09:48 AM Test Summary: 32528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8365
-
Benjamin Franzke commented on patch set 3 12/21/20, 09:53
Some comments regarding the custom element for now. Don't had the time to look at the rest yet, sorry.DeleteRecordElement.ts:29Would prefer to drop "element-" here. That's like a bit like: class FooClass { :)DeleteRecordElement.ts:37This event should be added in connectedCallback and removed in disconnectCallback. See https://lit-element.polymer-project.org/guide/events#add-event-listners-in-connectedcallbackDeleteRecordElement.ts:47Hm.. Is adding a button like html`<button class="btn.." @click="${...}">${icon('actions-delete')}</button>` an option here? That would allow the event handler to be applies inline and for classes to be integrated. Then we'd add two more properties, "size" and "style" which're reflected to the button classes. -
Andreas Kienast commented on patch set 3 12/21/20, 16:14
DeleteRecordElement.ts:29ReplyAckDeleteRecordElement.ts:37Reply UnresolvedI did it this way on purpose, the docs also say: "If your component adds an event listener to anything except itself [...] you should add the listener in connectedCallback and remove it in disconnectedCallback." Now I'm confused :)DeleteRecordElement.ts:47Reply UnresolvedI tried building the button markup in this element but that causes a visual glitch as it's primarily used in a `.btn-group` -
Andreas Kienast abandoned the change 08/30/21, 20:40
AjaxDataHandler.ts:142Unresolved