Review main Merged

67215[TASK] Update bootstrap javascript to 5.0.0-beta1

Benjamin Franzke CR +2 V +2 Hard +361 −292 updated 12/21/20, 14:45

Commit message

Bootstrap v5 – introduced in #92616 – was added with CCS from beta1 but
JavaScript from alpha2. bootstrap.bundle.js was manually wrapped
into a AMD closure, and because bootstrap 5.0.0-beta1 contains alot of
changes regarding data tags, it couldn't be updated in the initial
patch.

Bootstrap is now bundled using rollup using the ES6 sources in order
to allow for automatic updates through `grunt build`.

popperjs – previously bundled into bootstrap distributed files –
is now added as dependency. The bootstap ES6 sources, that we now use
through rollup, do not bundle this external dependency (for good reasons).

Dependency added with:

   yarn add @popperjs/core

Further adaptions contained in this change to ensure beta1 compatibility:

a) Carousel "item" to "carousel-item" class migration
b) $.fn.modal(options) does no longer imply $.fn.modal('show')
c) Fix panels, both JS and CSS (card-group can't be used here)
d) All bootstrap data- tags are migrated to data-bs-.
   (see https://github.com/twbs/bootstrap/pull/31827)
   Migrated with

   # renderes a sed substition with the help of a nested sed from all the
   # data-bs attributes that where changed in the twbs/bootstrap commit
   git grep -l data- | xargs sed -i $( \
        curl -s \
        https://patch-diff.githubusercontent.com/raw/twbs/bootstrap/pull/31827.patch | \
        sed 's/data-bs-[a-z-]*/\n&\n/g' | grep "data-bs-[a-z-]" | \
        sort | uniq | \
        sed 's/data-bs-\(.*\)\([^a-z-]\|$\)/ -e s\/data-\1\\\([^a-z-]\\\)\/data-bs-\1\\1\/g -e s\/data('"'"'\1'"'"')\/data('"'"'bs-\1'"'"')\/g/g' \
   )

   # Revert false positives from the above auto-replacement
   git checkout -- typo3/sysext/core/Documentation/Changelog/ \
        typo3/sysext/backend/Classes/Form/Container/FlexFormContainerContainer.php \
        Build/Sources/TypeScript/backend/Resources/Public/TypeScript/LiveSearch.ts \
        Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngineFlexForm.ts \
        Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Settings/ExtensionConfiguration.ts \
        Build/Sources/Sass/typo3/_element_panel.scss

   (cd Build && grunt build)

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Martin Kutschker +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Martin Kutschker +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 4

Files 125

Show 105 more files

Review log 2135

Show 510 earlier messages
  1. Benjamin Franzke uploaded patch set 1 12/20/20, 16:53

  2. TYPO3com voted on patch set 1 V -1 12/20/20, 17:03 Completed build in 09m 34s on Sun, 20 Dec, 05:03 PM Test Summary: 2 of 32650 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8349

  3. Benjamin Franzke uploaded patch set 2 12/20/20, 19:03

  4. TYPO3com voted on patch set 2 V -1 12/20/20, 19:15 Completed build in 10m 38s on Sun, 20 Dec, 07:15 PM Test Summary: 13 of 32769 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8352

  5. Benjamin Franzke uploaded patch set 3 12/20/20, 19:19

  6. TYPO3com voted on patch set 3 V -1 12/20/20, 19:29 Completed build in 10m 05s on Sun, 20 Dec, 07:29 PM Test Summary: 12 of 32769 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8354

  7. Benjamin Franzke uploaded patch set 4 12/20/20, 19:42

  8. TYPO3com voted on patch set 4 V -1 12/20/20, 19:51 Completed build in 08m 47s on Sun, 20 Dec, 07:51 PM Test Summary: 5 of 32712 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8355

  9. Benjamin Franzke uploaded patch set 5 12/20/20, 22:13

  10. TYPO3com voted on patch set 5 V -1 12/20/20, 22:22 Completed build in 08m 55s on Sun, 20 Dec, 10:22 PM Test Summary: 3 of 32769 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8359

  1. Benjamin Franzke uploaded patch set 6 12/20/20, 23:11

  2. TYPO3com voted on patch set 6 V +1 12/20/20, 23:23 Completed build in 10m 55s on Sun, 20 Dec, 11:23 PM Test Summary: 32528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8360

  3. Benjamin Franzke uploaded patch set 7 12/21/20, 00:00

  4. TYPO3com voted on patch set 7 V +1 12/21/20, 00:10 Completed build in 09m 54s on Mon, 21 Dec, 12:10 AM Test Summary: 32528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8361

  5. Benjamin Franzke uploaded patch set 8 12/21/20, 08:57

  6. TYPO3com voted on patch set 8 V +1 12/21/20, 09:07 Completed build in 09m 42s on Mon, 21 Dec, 09:07 AM Test Summary: 32528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8362

  7. Benjamin Franzke uploaded patch set 9 12/21/20, 09:18

  8. TYPO3com voted on patch set 9 V +1 12/21/20, 09:29 Completed build in 10m 14s on Mon, 21 Dec, 09:29 AM Test Summary: 32528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8363

  9. Benjamin Franzke uploaded patch set 10 12/21/20, 09:42

  10. TYPO3com voted on patch set 10 V +1 12/21/20, 09:57 Completed build in 11m 18s on Mon, 21 Dec, 09:57 AM Test Summary: 32528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8367

  11. Benjamin Franzke uploaded patch set 11 12/21/20, 10:35

  12. TYPO3com voted on patch set 11 V +1 12/21/20, 10:45 Completed build in 10m 14s on Mon, 21 Dec, 10:45 AM Test Summary: 32528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8369

  13. Benjamin Franzke updated the commit message in patch set 12 12/21/20, 10:53

  14. TYPO3com voted on patch set 12 V +1 12/21/20, 11:05 Completed build in 12m 03s on Mon, 21 Dec, 11:05 AM Test Summary: 32528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8370

  15. Benjamin Franzke commented on patch set 12 12/21/20, 11:05

    Unresolved

    will change to "d" in case we need another patchset (or, if someone else pushes, then please change this)
  16. Benni Mack uploaded patch set 13 12/21/20, 13:12

  17. Benni Mack voted on patch set 13 V +1 CR +1 12/21/20, 13:13

  18. TYPO3com voted on patch set 13 V +1 12/21/20, 13:23 Completed build in 10m 58s on Mon, 21 Dec, 01:23 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8372

  19. Benni Mack updated the commit message in patch set 14 12/21/20, 13:32

  20. Benni Mack voted on patch set 14 V +1 CR +1 12/21/20, 13:33

  21. TYPO3com voted on patch set 14 V +1 12/21/20, 13:42 Completed build in 09m 27s on Mon, 21 Dec, 01:42 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8374

  22. Martin Kutschker voted on patch set 14 V +1 CR +1 12/21/20, 14:20

  23. Christian Kuhn voted on patch set 14 V +1 CR +1 12/21/20, 14:38

  24. Benni Mack voted on patch set 14 V +2 CR +2 12/21/20, 14:45

  25. Benni Mack merged patch set 15 12/21/20, 14:45