Review main Merged

67219[TASK] Remove AbstractRequestHandler

Alexander Schnitzler CR +2 V +2 Normal +40 −90 updated 12/23/20, 09:10

Commit message

The AbstractRequestHandler was an abstract class
which didn't add any helper method at all, concrete
implementations did benefit from.

In fact, it even implemented a contract method, which
should notbe done by an abstract class but only by
specific implementations.

Besides that, only DI methods had been shared which
also just hides the dependencies of the specific
implementations.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 810

  1. Alexander Schnitzler uploaded patch set 1 12/21/20, 13:19

  2. TYPO3com voted on patch set 1 V +1 12/21/20, 13:29 Completed build in 09m 56s on Mon, 21 Dec, 01:29 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8373

  3. Alexander Schnitzler wrote 12/22/20, 11:46

    Topic set to extbase
  4. Alexander Schnitzler uploaded patch set 2 12/22/20, 15:33

  5. TYPO3com voted on patch set 2 V +1 12/22/20, 15:42 Completed build in 09m 19s on Tue, 22 Dec, 03:42 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8438

  6. Benjamin Franzke voted on patch set 2 V +1 CR +1 12/22/20, 21:06

  7. Andreas Kienast voted on patch set 2 V +2 CR +2 12/23/20, 06:56

  8. Andreas Kienast merged patch set 3 12/23/20, 06:56

  9. Stephan Großberndt commented on patch set 3 12/23/20, 08:26

    PHPDoc for the new getPriority() methods is missing. Is this on purpose?
  10. Benjamin Franzke commented on patch set 3 12/23/20, 09:10

    Reply

    Yes, we avoid PHPDoc when the method is fully typed (parameter and return type declarations), as the PHPDoc would therefore contain zero "new" information, only redundancy. Also a description for this kind of method isn't needed.