67219[TASK] Remove AbstractRequestHandler
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 810
-
Alexander Schnitzler uploaded patch set 1 12/21/20, 13:19
-
TYPO3com voted on patch set 1 V +1 12/21/20, 13:29 Completed build in 09m 56s on Mon, 21 Dec, 01:29 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8373
-
Alexander Schnitzler wrote 12/22/20, 11:46
Topic set to extbase -
Alexander Schnitzler uploaded patch set 2 12/22/20, 15:33
-
TYPO3com voted on patch set 2 V +1 12/22/20, 15:42 Completed build in 09m 19s on Tue, 22 Dec, 03:42 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8438
-
Benjamin Franzke voted on patch set 2 V +1 CR +1 12/22/20, 21:06
-
Andreas Kienast voted on patch set 2 V +2 CR +2 12/23/20, 06:56
-
Andreas Kienast merged patch set 3 12/23/20, 06:56
-
Stephan Großberndt commented on patch set 3 12/23/20, 08:26
PHPDoc for the new getPriority() methods is missing. Is this on purpose? -
Benjamin Franzke commented on patch set 3 12/23/20, 09:10
Reply
Yes, we avoid PHPDoc when the method is fully typed (parameter and return type declarations), as the PHPDoc would therefore contain zero "new" information, only redundancy. Also a description for this kind of method isn't needed.