Review main Merged

67222[BUGFIX] Fix styling for various Backend items

Benni Mack CR +2 V +2 Normal +45 −45 updated 12/21/20, 16:50

Commit message

Due to the Bootstrap Update, some custom functionality
by TYPO3 is not needed anymore and can be simplified:

* No need for caret in SplitButton anymore (Clipboard, History)
* Simplified horizontal filter menu (TSOB, Indexed Search Menu)
* Better grid in EXT:forms module
* Adjustments to autocomplete / FormEngine suggest field

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 1217

  1. Benni Mack uploaded patch set 1 12/21/20, 15:22

  2. TYPO3com voted on patch set 1 V +1 12/21/20, 15:35 Completed build in 11m 16s on Mon, 21 Dec, 03:35 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8380

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 12/21/20, 15:52

  4. Oli Bartsch commented on patch set 1 CR -1 12/21/20, 15:59

    Still some duplicated clear buttons in ts_template objectBrowser. Will have a look.
  5. Benjamin Franzke voted on patch set 1 V +1 CR +1 12/21/20, 16:08

  6. Tobias Wollender commented on patch set 1 12/21/20, 16:14

    InsertElements.html:13

    I think "col-4 col-sm-4" could be simplified to just "col-4", no? Or should this be a different col-x modifier for smaller screen sizes? Don't know where this is used - I just read the code, sorry.
  7. Oli Bartsch uploaded patch set 2 12/21/20, 16:17

  8. Oli Bartsch voted on patch set 2 V +1 CR +1 12/21/20, 16:18

  9. Benjamin Franzke uploaded patch set 3 12/21/20, 16:25

  10. Benjamin Franzke commented on patch set 3 12/21/20, 16:25

    InsertElements.html:13 Reply

    Ack
  11. TYPO3com voted on patch set 2 V +1 12/21/20, 16:27 Completed build in 10m 11s on Mon, 21 Dec, 04:27 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8385

  12. Oli Bartsch voted on patch set 3 V +1 CR +1 12/21/20, 16:28

  13. TYPO3com voted on patch set 3 V -1 12/21/20, 16:36 Completed build in 10m 38s on Mon, 21 Dec, 04:36 PM Test Summary: 1 of 32781 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8386

  14. TYPO3com voted on patch set 3 V +1 12/21/20, 16:47 Completed build in 10m 19s on Mon, 21 Dec, 04:47 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8387

  15. Benni Mack voted on patch set 3 V +2 CR +2 12/21/20, 16:47

  16. Benni Mack merged patch set 4 12/21/20, 16:47

  17. TYPO3com commented on patch set 3 12/21/20, 16:50 Completed build in 35m 24s on Mon, 21 Dec, 04:50 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8386