67223[TASK] Drop non hashed session fallback
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/beuser/Classes/Controller/BackendUserController.php+1 −2
- typo3/sysext/core/Classes/Session/Backend/DatabaseSessionBackend.php+4 −24
- typo3/sysext/core/Classes/Session/Backend/RedisSessionBackend.php+1 −13
- typo3/sysext/core/Tests/Functional/Session/Backend/RedisSessionBackendTest.php+0 −25
Review log 1217
-
Christian Kuhn uploaded patch set 1 12/21/20, 16:52
-
TYPO3com voted on patch set 1 V -1 12/21/20, 17:03 Completed build in 10m 30s on Mon, 21 Dec, 05:03 PM Test Summary: 3 of 32781 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8389
-
Christian Kuhn uploaded patch set 2 12/21/20, 17:03
-
Oliver Hader commented on patch set 2 12/21/20, 17:05
https://review.typo3.org/c/Packages/TYPO3.CMS/+/66664 had a bunch of additional fall-backs (when removing plain-text sessions ID and so) -
TYPO3com voted on patch set 2 V +1 12/21/20, 17:13 Completed build in 10m 02s on Mon, 21 Dec, 05:13 PM Test Summary: 32537 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8390
-
Christian Kuhn commented on patch set 2 CR -1 12/21/20, 17:14
will update -
Christian Kuhn uploaded patch set 3 12/21/20, 17:35
-
TYPO3com voted on patch set 3 V -1 12/21/20, 17:45 Completed build in 09m 11s on Mon, 21 Dec, 05:45 PM Test Summary: 6 of 32778 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8391
-
Christian Kuhn commented on patch set 3 CR -1 12/21/20, 17:50
needs finetuning. -
Christian Kuhn uploaded patch set 4 12/21/20, 18:01
-
TYPO3com voted on patch set 4 V -1 12/21/20, 18:12 Completed build in 10m 43s on Mon, 21 Dec, 06:12 PM Test Summary: 1 of 32778 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8394
-
TYPO3com voted on patch set 4 V +1 12/21/20, 18:19 Completed build in 28m 12s on Mon, 21 Dec, 06:19 PM Test Summary: 32537 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8394
-
Benni Mack voted on patch set 4 CR +1 12/29/20, 21:32
-
Benni Mack voted on patch set 4 V +1 01/04/21, 14:39
-
Oli Bartsch voted on patch set 4 V +1 CR +1 01/04/21, 16:21
-
Christian Kuhn voted on patch set 4 V +2 CR +2 01/04/21, 16:24
-
Christian Kuhn merged patch set 5 01/04/21, 16:24