Review main Merged

67226[TASK] Make TreeNodeCollection compatible with PHP 8

Jörn Wagner CR +2 V +2 Easy +3 −1 updated 12/22/20, 10:23

Commit message

Adds the new parameter in ArrayObject::asort for PHP 8. As an additional parameter it's backwards-compatible with PHP 7.4.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 1116

  1. Jörn Wagner uploaded patch set 1 12/21/20, 19:43

  2. TYPO3com voted on patch set 1 V -1 12/21/20, 19:43 Completed build in 25s on Mon, 21 Dec, 07:43 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8397

  3. Georg Ringer commented on patch set 1 12/21/20, 19:58

    the releases must be "master, 10.4"
  4. Jörn Wagner uploaded patch set 2 12/21/20, 19:59

  5. Jörn Wagner updated the commit message in patch set 3 12/21/20, 20:00

  6. TYPO3com voted on patch set 2 V -1 12/21/20, 20:13 Completed build in 13m 33s on Mon, 21 Dec, 08:13 PM Test Summary: 31068 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8399

  7. TYPO3com voted on patch set 3 V -1 12/21/20, 20:18 Completed build in 17m 04s on Mon, 21 Dec, 08:18 PM Test Summary: 32528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8400

  8. Jörn Wagner updated the commit message in patch set 4 12/21/20, 22:53

  9. TYPO3com voted on patch set 4 V +1 12/21/20, 23:04 Completed build in 11m 10s on Mon, 21 Dec, 11:04 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8412

  10. Alexander Schnitzler commented on patch set 4 CR -1 12/22/20, 07:50

    TreeNodeCollection.php:45

    Telling the user that the flags are optional is only half the truth. The other half is, that they are not respected which is the more important part imho. We should state that we do this to be compatible with the method declaration of asort in php8 but that setting flags does not have any impact.
  11. Jörn Wagner uploaded patch set 5 12/22/20, 08:00

  12. Jörn Wagner commented on patch set 5 12/22/20, 08:00

    TreeNodeCollection.php:45 Reply

    Acknowledged. As I looked deeper into the code, it also would not make much sense to accept any other flags as we're comparing node objects that are sorted by their ID value.
  13. Alexander Schnitzler voted on patch set 5 V +1 CR +1 12/22/20, 08:02

  14. TYPO3com voted on patch set 5 V +1 12/22/20, 08:10 Completed build in 09m 30s on Tue, 22 Dec, 08:10 AM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8419

  15. Christian Kuhn voted on patch set 5 V +2 CR +2 12/22/20, 10:23

  16. Christian Kuhn merged patch set 6 12/22/20, 10:23