Review main Merged

67227[TASK] Make first install compatible with PHP 8

Jörn Wagner CR +2 V +2 Normal +86 −27 updated 01/04/21, 09:26

Commit message

Make all the necessary changes to classes used during the first installation to run on PHP 8

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 2738

Show 913 earlier messages
  1. Jörn Wagner uploaded patch set 1 12/21/20, 19:55

  2. TYPO3com voted on patch set 1 V -1 12/21/20, 19:56 Completed build in 26s on Mon, 21 Dec, 07:56 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8398

  3. Georg Ringer commented on patch set 1 12/21/20, 19:57

    the releases must be "master, 10.4"
  4. Jörn Wagner updated the commit message in patch set 2 12/21/20, 20:00

  5. TYPO3com voted on patch set 2 V -1 12/21/20, 20:03 Completed build in 01m 25s on Mon, 21 Dec, 08:03 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8401

  6. Jörn Wagner uploaded patch set 3 12/21/20, 20:04

  7. Jörn Wagner commented on patch set 3 12/21/20, 20:07

    This change is ready for review.

    Reply

    Must be exactly that string or can the value also be just "master" if it's only intended for v11?
  8. Oli Bartsch commented on patch set 3 12/21/20, 20:18

    Reply

    Generally just add versions a patch is intended for. Master must be added in any case. See https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/Appendix/CommitMessage.html So, this patch should only get “master”.
  9. TYPO3com voted on patch set 3 V -1 12/21/20, 20:19 Completed build in 06m 23s on Mon, 21 Dec, 08:19 PM Test Summary: 3 of 20953 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8403

  10. Jörn Wagner commented on patch set 3 12/21/20, 20:24

    Reply

    I was thinking, with 11.0 due to be released tomorrow this patch might sit here a little longer. But I guess 11.0 will still stay master until the LTS version 11.5?
  11. Jörn Wagner uploaded patch set 4 12/21/20, 22:52

  12. TYPO3com voted on patch set 4 V -1 12/21/20, 23:02 Completed build in 10m 07s on Mon, 21 Dec, 11:02 PM Test Summary: 4 of 32781 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8411

  13. Alexander Schnitzler commented on patch set 4 12/22/20, 15:50

    PDOStatement.php:24

    To be honest, that's quite ugly. Two classes in one file and wrapped in this condition... Is this whole change to doctrine/dbal not updated yet?

    ErrorHandler.php:260

    Let's add a proper return type hint here along with this change and drop the phpdoc.

    Check.php:853 Unresolved

    I'd prefer a oneliner here. > return is_resource($imageResource) || (PHP_MAJOR_VERSION >= 8 && $imageResource instanceof \GdImage); It also avoids two checks for the majority of users out there (those on 7.4).
  1. Jörn Wagner marked it work in progress 12/22/20, 16:08

  2. Jörn Wagner commented on patch set 4 12/22/20, 16:13

    This change is ready for review.

    PDOStatement.php:24 Reply

    I know it's ugly but I didn't find any other solution. The dependency to doctrine/dbal was upgraded to ^2.12 with https://review.typo3.org/c/Packages/TYPO3.CMS/+/66971, but PHP 8 complains that the method signature doesn't match and if it's changed then PHP 7.4 complains it doesn't match. Takeaway: Never overload framework methods. If this method would be called differently than "fetchAll" it wouldn't be so much of a problem. Maybe https://review.typo3.org/c/Packages/TYPO3.CMS/+/67116 might help? But it's a huge change
  3. Jörn Wagner marked it work in progress 12/22/20, 16:13

  4. Jörn Wagner commented on patch set 4 12/23/20, 08:19

    PDOStatement.php:24 Reply Unresolved

    This is pretty standard, I didn't make it up. It was actually inspired by https://github.com/doctrine/dbal/blob/2.12.x/lib/Doctrine/DBAL/Driver/PDOStatementImplementations.php

    ErrorHandler.php:260 Reply Unresolved

    Agreed. I was trying not to interfere with https://review.typo3.org/c/Packages/TYPO3.CMS/+/64426
  5. Jörn Wagner uploaded patch set 5 12/23/20, 08:36

  6. Jörn Wagner commented on patch set 5 12/23/20, 08:39

    This change is ready for review.
  7. TYPO3com voted on patch set 5 V -1 12/23/20, 08:46 Completed build in 09m 46s on Wed, 23 Dec, 08:46 AM Test Summary: 1 of 32781 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8451

  8. Jörn Wagner commented on patch set 5 12/23/20, 08:54

    Phpstan is complaining that there is no class named "\GdImage" in PHP 7.4. I don't know how to fix that. The duplicateExceptionCodeCheck is funny, because I just moved the code from PDOStatement that was there before. Is there an exemption made to this class? I can add a 10-digit code of course if you like. Also there's a failure in Acceptance/Backend/PageTree/PageTreeFilterCest.php:deletingPageWithFilterAppliedRespectsFilterUponPageTreeReload, I will look into that.
  9. TYPO3com commented on patch set 5 01/01/21, 14:01 Completed build in 5h 34m 49s on Fri, 1 Jan, 02:01 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8451

  10. Daniel Goerz commented on patch set 5 01/02/21, 09:58

    Reply Unresolved

    As for the phpstan error. As this is no "real" issue, you can add it to the ignored errors in the phpstan.neon file
  11. Benni Mack uploaded patch set 6 01/02/21, 12:56

  12. Benni Mack wrote 01/02/21, 12:58

    Topic set to PHP8
  13. TYPO3com voted on patch set 6 V +1 01/02/21, 13:07 Completed build in 10m 10s on Sat, 2 Jan, 01:07 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8551

  14. Benni Mack voted on patch set 6 V +1 CR +1 01/02/21, 19:39

  15. Benni Mack updated the commit message in patch set 7 01/02/21, 21:00

  16. Benni Mack updated the commit message in patch set 8 01/02/21, 21:01

  17. Benni Mack voted on patch set 8 V +1 CR +1 01/02/21, 21:06

  18. TYPO3com voted on patch set 7 V +1 01/02/21, 21:09 Completed build in 08m 40s on Sat, 2 Jan, 09:09 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8556

  19. TYPO3com voted on patch set 8 V -1 01/02/21, 21:14 Completed build in 10m 07s on Sat, 2 Jan, 09:13 PM Test Summary: 1 of 32781 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8557

  20. TYPO3com voted on patch set 8 V +1 01/04/21, 07:19 Completed build in 10h 25m 48s on Mon, 4 Jan, 07:19 AM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8557

  21. Benni Mack commented on patch set 9 01/04/21, 08:46

    Published edit on patch set 8.
  22. TYPO3com voted on patch set 9 V +1 01/04/21, 08:58 Completed build in 11m 57s on Mon, 4 Jan, 08:58 AM Test Summary: 32546 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8579

  23. Benni Mack voted on patch set 9 V +1 CR +1 01/04/21, 09:15

  24. Benjamin Franzke voted on patch set 9 V +2 CR +2 01/04/21, 09:25

  25. Benjamin Franzke merged patch set 10 01/04/21, 09:26