Review main Merged

67228[BUGFIX] Better deprecation log in extbase controller action

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 12/21/20, 20:29

Commit message

When extbase controller action don't return a ResponseInterface,
a deprecation log is raised:

"Controller action TYPO3\CMS\Extbase\Mvc\Controller\ActionController:: does not return ..."

Using late static binding and proper action name resolving
changes this to a much more helpful message:

"Controller action TYPO3\CMS\Styleguide\Controller\StyleguideController->tabAction does not return ..."

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 12/21/20, 20:01

  2. Anja Leichsenring voted on patch set 1 V +1 CR +1 12/21/20, 20:09

  3. TYPO3com voted on patch set 1 V +1 12/21/20, 20:20 Completed build in 18m 04s on Mon, 21 Dec, 08:20 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8402

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 12/21/20, 20:21

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 12/21/20, 20:29

  6. Christian Kuhn merged patch set 2 12/21/20, 20:29