Review main Merged

67231[BUGFIX] Remove extra card stylings introduced with Bootstrap 5

Martin Kutschker CR +2 V +2 Easy +19 −2 updated 12/22/20, 07:57

Commit message

Remove background of card header and bottom/top border of
card header/footer so the style does not change from TYPO3 v10
to v11.

Also re-add checkbox-type-toggle absolute positioning of the
hidden checkbox in order to avoid upper spacing above checkbox
toggle elements (causes too much spacing in feature cards).

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 710

  1. Martin Kutschker uploaded patch set 1 12/21/20, 20:59

  2. Martin Kutschker commented on patch set 1 12/21/20, 21:01

    Unresolved

    Make cards in v11 look like in v10.
  3. TYPO3com voted on patch set 1 V +1 12/21/20, 21:10 Completed build in 11m 21s on Mon, 21 Dec, 09:10 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8407

  4. Benjamin Franzke commented on patch set 1 CR -1 12/22/20, 06:57

    on it
  5. Benjamin Franzke uploaded patch set 2 12/22/20, 07:24

  6. Benjamin Franzke commented on patch set 2 12/22/20, 07:24

    _card.scss:312

    we still have too much padding in feature toggles. Will therefore adapt the checkbox upper margin.

    _card.scss:327

    we already a a sepearte card-header block in this file, will fix.

    _card.scss:329

    duplicate.
  7. TYPO3com voted on patch set 2 V -1 12/22/20, 07:33 Completed build in 09m 07s on Tue, 22 Dec, 07:33 AM Test Summary: 1 of 32781 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8416

  8. TYPO3com voted on patch set 2 V +1 12/22/20, 07:52 Completed build in 37m 34s on Tue, 22 Dec, 07:52 AM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8416

  9. Benni Mack voted on patch set 2 V +2 CR +2 12/22/20, 07:57

  10. Benni Mack merged patch set 3 12/22/20, 07:57