Review main Merged

67232[BUGFIX] Style installer steps

Benni Mack CR +2 V +2 Hard +438 −396 updated 12/22/20, 06:56

Commit message

The installation process now uses
floating inputs, and sorts
the yellow box on step 4 properly.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Simon Gilli +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Simon Gilli +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 811

  1. Benni Mack uploaded patch set 1 12/21/20, 21:43

  2. TYPO3com voted on patch set 1 V -1 12/21/20, 21:56 Completed build in 13m 08s on Mon, 21 Dec, 09:56 PM Test Summary: 4 of 31931 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8408

  3. Simon Gilli voted on patch set 1 V +1 CR +1 12/21/20, 22:01

  4. TYPO3com commented on patch set 1 12/21/20, 23:46 Completed build in 13m 27s on Mon, 21 Dec, 11:46 PM Test Summary: 3 of 32781 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8413

  5. Benjamin Franzke uploaded patch set 2 12/22/20, 00:05

  6. Benjamin Franzke commented on patch set 2 12/22/20, 00:11

    ShowDatabaseData.html:42 Unresolved

    I know, this is really ugly, with all the inline stuff. But I see this as a custom html element later on (lit-html). And therefore it's not worth to add this to global css/scripts right now.. And it used inline js before (see below).
  7. TYPO3com voted on patch set 2 V +1 12/22/20, 00:17 Completed build in 11m 38s on Tue, 22 Dec, 12:17 AM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8415

  8. Simon Gilli voted on patch set 2 V +1 CR +1 12/22/20, 00:18

  9. Benjamin Franzke commented on patch set 2 V +1 CR +1 12/22/20, 00:20

    Code-Review +1, but I'll wait with the merge, as I introduced the two column layout in patchset 2 and I'll want to give Benni a chance to intervene, if needed.
  10. Benni Mack commented on patch set 2 V +2 CR +2 12/22/20, 06:56

    Thanks @bnf!
  11. Benni Mack merged patch set 3 12/22/20, 06:56