67232[BUGFIX] Style installer steps
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- Simon Gilli +1
-
Verified V +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- Simon Gilli +1
- TYPO3com +1 CI
Issues 1
Files 9
- Build/Sources/Sass/typo3/_install.scss+2 −2
- Build/Sources/Sass/variables/_main.scss+2 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/core/Tests/Acceptance/Install/Mysql/BlankPageCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Install/Postgresql/BlankPageCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Install/Sqlite/BlankPageCest.php+1 −1
- typo3/sysext/install/Resources/Private/Templates/Installer/ShowDatabaseConnect.html+357 −316
- typo3/sysext/install/Resources/Private/Templates/Installer/ShowDatabaseData.html1+59 −64
- typo3/sysext/install/Resources/Private/Templates/Installer/ShowDatabaseSelect.html+14 −10
Review log 811
-
Benni Mack uploaded patch set 1 12/21/20, 21:43
-
TYPO3com voted on patch set 1 V -1 12/21/20, 21:56 Completed build in 13m 08s on Mon, 21 Dec, 09:56 PM Test Summary: 4 of 31931 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8408
-
Simon Gilli voted on patch set 1 V +1 CR +1 12/21/20, 22:01
-
TYPO3com commented on patch set 1 12/21/20, 23:46 Completed build in 13m 27s on Mon, 21 Dec, 11:46 PM Test Summary: 3 of 32781 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8413
-
Benjamin Franzke uploaded patch set 2 12/22/20, 00:05
-
Benjamin Franzke commented on patch set 2 12/22/20, 00:11
-
TYPO3com voted on patch set 2 V +1 12/22/20, 00:17 Completed build in 11m 38s on Tue, 22 Dec, 12:17 AM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8415
-
Simon Gilli voted on patch set 2 V +1 CR +1 12/22/20, 00:18
-
Benjamin Franzke commented on patch set 2 V +1 CR +1 12/22/20, 00:20
Code-Review +1, but I'll wait with the merge, as I introduced the two column layout in patchset 2 and I'll want to give Benni a chance to intervene, if needed. -
Benni Mack commented on patch set 2 V +2 CR +2 12/22/20, 06:56
Thanks @bnf! -
Benni Mack merged patch set 3 12/22/20, 06:56
ShowDatabaseData.html:42Unresolved