Review main Merged

67240[BUGFIX] Fix items text color in EXT:viewpage module

Oli Bartsch CR +2 V +2 Easy +24 −13 updated 12/22/20, 20:42

Commit message

The text color of EXT:viewpage module options has got
the necessary contrast again. Furthermore the duplicated
"arrow-down" indicator removed, and the dropdown menu
is adapted for bootstrap 5 markup to fix padding of
dropdown items. Also a proper focus and hover state
is added.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1723

  1. Oli Bartsch uploaded patch set 1 12/22/20, 10:17

  2. Oli Bartsch updated the commit message in patch set 2 12/22/20, 10:18

  3. TYPO3com voted on patch set 1 V +1 12/22/20, 10:28 Completed build in 10m 09s on Tue, 22 Dec, 10:28 AM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8427

  4. TYPO3com voted on patch set 2 V -1 12/22/20, 10:33 Completed build in 10m 54s on Tue, 22 Dec, 10:33 AM Test Summary: 1 of 32781 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8428

  5. TYPO3com voted on patch set 2 V +1 12/22/20, 10:38 Completed build in 26m 42s on Tue, 22 Dec, 10:38 AM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8428

  6. TYPO3com commented on patch set 2 12/22/20, 10:48 Completed build in 09m 24s on Tue, 22 Dec, 10:48 AM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8431

  7. Oli Bartsch wrote 12/22/20, 10:52

    Topic set to bootstrap5
  8. Benni Mack commented on patch set 2 12/22/20, 12:47

    Show.html:18

    do we still need the "caret"? I don#t think so.
  9. Christian Kuhn commented on patch set 2 V +1 CR +1 12/22/20, 13:21

    Show.html:18 Reply

    Well, it's an indicator you can click this. I actually tend to keep it.
  10. Oli Bartsch commented on patch set 2 12/22/20, 14:17

    Show.html:18 Reply

    Yes, we need at least some kind of indication that it's a dropdown. Bootstrap5 automatically assigns a pseudo element `:after` to the `dropdown-toggle` class for this purpose. Thats why we got two indicators after the upgrade. I however think we should stick to the `caret` element to use a real DOM node instead of a pseudo element. That's how it's currently done through the core.
  11. Benni Mack commented on patch set 2 12/22/20, 14:20

    Show.html:18 Reply

    hmm, OK. I removed the "caret" tag from various places the last few days in favor of "dropdown-toggle" ;)
  12. Martin Kutschker commented on patch set 2 12/22/20, 15:34

    Show.html:14

    The aria-haspop is wrong. It announces an application style menu, which requires cursor key navigation. The "menu" uses tab only, though it supports ESC for closing it. ARIA attributes should only be used if the patterns that go with them are fully implemented. Sidenote: Actually a select is more appropiate anyway. The labelling of the button and the list is awkward. The focus style is also missing.
  13. Oli Bartsch commented on patch set 2 12/22/20, 15:41

    Show.html:14 Reply

    Agree but that was not the purpose of this patch. There is surely more to adjust regarding a11y in viewpage. Fine for you to create separate patch and improving these topics there?
  14. Martin Kutschker uploaded patch set 3 12/22/20, 15:59

  15. Martin Kutschker commented on patch set 2 12/22/20, 16:00

    Show.html:14 Reply

    The focus is missing because the SPAN had the color set and not the button.

    Show.html:18 Reply

    Done
  16. Martin Kutschker commented on patch set 3 V +1 CR +1 12/22/20, 16:03

    Show.html:14 Reply Unresolved

    Sure. I noticed that the dropdown pattern is used in more places in the, so it's better to fix it not in this patch.
  17. TYPO3com voted on patch set 3 V +1 12/22/20, 16:10 Completed build in 10m 34s on Tue, 22 Dec, 04:10 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8439

  18. Christian Kuhn voted on patch set 3 V +1 CR +1 12/22/20, 16:53

  19. Benjamin Franzke commented on patch set 3 CR -1 12/22/20, 20:00

    The caret is not positioned in line with the text. That is because the inner span has a custom vertical align applied. Let's also fix the associated dropdown menu. It contains wrong markup and therefore missing padding. Will take care.
  20. Benjamin Franzke uploaded patch set 4 12/22/20, 20:16

  21. TYPO3com voted on patch set 4 V +1 12/22/20, 20:26 Completed build in 09m 41s on Tue, 22 Dec, 08:26 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8445

  22. Benni Mack voted on patch set 4 V +2 CR +2 12/22/20, 20:42

  23. Benni Mack merged patch set 5 12/22/20, 20:42