67241[TASK] Refactor low level console commands to avoid full boot
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Helmut Hummel +1
-
Verified V +2 Done
- Benni Mack +2
- Helmut Hummel +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 2
Files 13
- typo3/sysext/core/Classes/Command/Descriptor/TextDescriptor.php+11 −1
- typo3/sysext/core/Classes/Command/ListCommand.php+18 −4
- typo3/sysext/core/Classes/Console/CommandApplication.php6+71 −18
- typo3/sysext/core/Classes/Core/BootService.php2new+155 −0
- typo3/sysext/core/Classes/DependencyInjection/ContainerBuilder.php+3 −0
- typo3/sysext/core/Classes/ServiceProvider.php+18 −2
- typo3/sysext/core/Resources/Private/Php/cli.php+1 −1
- typo3/sysext/core/composer.json+1 −1
- typo3/sysext/install/Classes/Command/UpgradeWizardListCommand.php+1 −1
- typo3/sysext/install/Classes/Command/UpgradeWizardRunCommand.php5+1 −1
- typo3/sysext/install/Classes/Service/LateBootService.php2+6 −124
- composer.json+1 −1
- composer.lock+11 −11
Review log 2754
Show 1229 earlier messages
-
Benjamin Franzke uploaded patch set 1 12/22/20, 13:11
-
TYPO3com voted on patch set 1 V -1 12/22/20, 13:20 Completed build in 08m 48s on Tue, 22 Dec, 01:20 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8432
-
Benjamin Franzke uploaded patch set 2 12/22/20, 13:39
-
TYPO3com voted on patch set 2 V -1 12/22/20, 13:48 Completed build in 09m 10s on Tue, 22 Dec, 01:48 PM Test Summary: 1 of 32781 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8433
-
TYPO3com commented on patch set 2 12/22/20, 14:09 Completed build in 09m 42s on Tue, 22 Dec, 02:09 PM Test Summary: 1 of 32781 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8434
-
TYPO3com voted on patch set 2 V +1 12/22/20, 19:42 Completed build in 08m 48s on Tue, 22 Dec, 07:42 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8442
-
Benjamin Franzke uploaded patch set 3 12/28/20, 15:14
-
TYPO3com voted on patch set 3 V +1 12/28/20, 15:25 Completed build in 09m 56s on Mon, 28 Dec, 03:25 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8472
-
Benjamin Franzke uploaded patch set 4 12/28/20, 21:07
-
Benjamin Franzke uploaded patch set 5 12/28/20, 21:10
-
TYPO3com voted on patch set 4 V +1 12/28/20, 21:17 Completed build in 09m 48s on Mon, 28 Dec, 09:17 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8481
-
TYPO3com voted on patch set 5 V +1 12/28/20, 21:20 Completed build in 09m 56s on Mon, 28 Dec, 09:20 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8482
-
Benjamin Franzke uploaded patch set 6 01/26/21, 20:06
-
TYPO3com voted on patch set 6 V +1 01/26/21, 20:17 Completed build in 10m 53s on Tue, 26 Jan, 08:17 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9074
-
Benjamin Franzke uploaded patch set 7 02/04/21, 14:50
-
TYPO3com voted on patch set 7 V -1 02/04/21, 14:50 Completed build in 18s on Thu, 4 Feb, 02:50 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9263
-
Benjamin Franzke uploaded patch set 8 02/04/21, 16:31
-
TYPO3com voted on patch set 8 V -1 02/04/21, 16:31 Completed build in 20s on Thu, 4 Feb, 04:31 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9265
-
core-ci voted on patch set 8 V +1 02/04/21, 16:43 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/380
-
Benjamin Franzke uploaded patch set 9 02/05/21, 00:15
-
TYPO3com voted on patch set 9 V -1 02/05/21, 00:15 Completed build in 19s on Fri, 5 Feb, 12:15 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9270
-
Benjamin Franzke uploaded patch set 10 02/05/21, 00:16
-
TYPO3com voted on patch set 10 V -1 02/05/21, 00:17 Completed build in 22s on Fri, 5 Feb, 12:17 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9271
-
core-ci voted on patch set 9 V +1 02/05/21, 00:26 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/387
-
core-ci voted on patch set 10 V +1 02/05/21, 00:32 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/388
-
Benjamin Franzke uploaded patch set 11 02/05/21, 12:32
-
TYPO3com voted on patch set 11 V -1 02/05/21, 12:33 Completed build in 01m 07s on Fri, 5 Feb, 12:33 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9293
-
core-ci voted on patch set 11 V +1 02/05/21, 12:42 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/410
-
Helmut Hummel commented on patch set 11 02/09/21, 09:52
CommandApplication.php:130this isn't and never will be true for TYPO3. I think we can skip that check
-
Benjamin Franzke uploaded patch set 12 02/09/21, 15:34
-
Benjamin Franzke commented on patch set 12 02/09/21, 15:34
CommandApplication.php:119ReplyFixed by booting the DI container if an exact low-level command match cannot be found. If `Application::find()` then returns a low level command, ext_localconf is not loaded. That means `bin/typo3 dumpautoload` is "safer" than `bin/typo3 du`, because latter may fail if the container is broken. But I think that is fine, as people (at least I do), will use full command names in scripts/deployments/etc…CommandApplication.php:130ReplyAck -
TYPO3com voted on patch set 12 V +1 02/09/21, 15:42 Completed build in 07m 57s on Tue, 9 Feb, 03:42 PM Test Summary: 32597 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9402
-
core-ci voted on patch set 12 V +1 02/09/21, 15:45 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/539
-
Benjamin Franzke uploaded patch set 13 02/10/21, 05:26
-
TYPO3com voted on patch set 13 V +1 02/10/21, 05:35 Completed build in 09m 27s on Wed, 10 Feb, 05:35 AM Test Summary: 32597 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9426
-
core-ci voted on patch set 13 V +1 02/10/21, 05:38 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/566
-
Benjamin Franzke uploaded patch set 14 02/12/21, 20:47
Resolve Merge Conflict -
TYPO3com voted on patch set 14 V +1 02/12/21, 20:56 Completed build in 09m 08s on Fri, 12 Feb, 08:56 PM Test Summary: 32611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9512
-
core-ci voted on patch set 14 V +1 02/12/21, 21:00 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/698
-
Benni Mack commented on patch set 14 02/16/21, 07:35
BootService.php:37you can use PHP 7.4 types already here. -
Benjamin Franzke uploaded patch set 15 02/16/21, 08:11
-
Benjamin Franzke commented on patch set 15 02/16/21, 08:11
BootService.php:37ReplyAck (background: As this class is moved from EXT:install to EXT:core I kept it as is – but you're right, it can be adapted). -
TYPO3com voted on patch set 15 V +1 02/16/21, 08:18 Completed build in 06m 51s on Tue, 16 Feb, 08:18 AM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9561
-
core-ci voted on patch set 15 V +1 02/16/21, 08:24 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/762
-
Benni Mack voted on patch set 15 V +1 CR +1 02/17/21, 21:12
-
Helmut Hummel commented on patch set 15 02/19/21, 15:04
Looks great already. Have some minor remarks, thoughThis isn't true any more, right?CommandApplication.php:88This variable isn't used, is it?UpgradeWizardRunCommand.php:81Make this part of the BootService API (basically include this call into initializeBackendAuthentication)? Or do we have a use case to only call one but not the other?UpgradeWizardRunCommand.php:82This is part of the BootService API. Maybe use it here?LateBootService.php:28Unused? -
Benjamin Franzke uploaded patch set 16 02/19/21, 20:16
-
Benjamin Franzke commented on patch set 16 02/19/21, 20:16
Reply
Oh, yes, true. Rephrased.CommandApplication.php:88Replyright, leftover from a previous patchset. Removed.UpgradeWizardRunCommand.php:81ReplyI thought about adding this to the BootService, but wasn't sure how, because currently this is also called in CommandApplication, and ideally I'd like to remove it there (for lowlevel commands). I furthermore don't know why this is added at all here. I'd like this as task for another patch/cleanup. So far the history, I then forgot that I added initializeBackendAuthentication() to BootService, but didn't actually use it anywhere. The problem was that the BootService is not just though for CLI but also for install tool, so I don't want to hardcode CommandLineUserAuthentication there. Would you be ok when I leave this as-is and rather remove unintended initializeBackendAuthentication from BootService? I'd like to sort the backendUser handling out later, and I'd be fine if someone added backendUser/Auth Handling to the BootService.UpgradeWizardRunCommand.php:82ReplyRemoved BootService->initializeBackendAuthentication, per comment for line 81.LateBootService.php:28ReplyAck, removed. -
TYPO3com voted on patch set 16 V +1 02/19/21, 20:24 Completed build in 07m 56s on Fri, 19 Feb, 08:24 PM Test Summary: 32684 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9641
-
core-ci voted on patch set 16 V +1 02/19/21, 20:27 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/861
-
Helmut Hummel commented on patch set 16 02/19/21, 20:35
UpgradeWizardRunCommand.php:81ReplyAck -
Helmut Hummel voted on patch set 16 V +1 CR +1 02/19/21, 20:50
-
Benni Mack voted on patch set 16 V +2 CR +2 02/19/21, 21:27
-
Benni Mack merged patch set 17 02/19/21, 21:27
CommandApplication.php:119