Review main Merged

67243[BUGFIX] Fix typing issues in various backend controllers

Benni Mack CR +2 V +2 Normal +43 −39 updated 06/14/21, 10:21

Commit message

This change aims to reduce all left-over strict type changes,
and backwards-incompatible changes in our own code base
making sure that TYPO3 can run smoothly with PHP 8.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 16

Review log 1831

Show 46 earlier messages
  1. Benni Mack uploaded patch set 1 12/22/20, 15:12

  2. TYPO3com voted on patch set 1 V -1 12/22/20, 15:20 Completed build in 07m 36s on Tue, 22 Dec, 03:20 PM Test Summary: 7808 of 32781 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8436

  3. Benni Mack abandoned the change 12/23/20, 07:31

  4. Benni Mack restored the change 01/04/21, 10:03

  5. Benni Mack uploaded patch set 2 01/04/21, 10:05

  6. TYPO3com voted on patch set 2 V +1 01/04/21, 10:15 Completed build in 10m 00s on Mon, 4 Jan, 10:15 AM Test Summary: 32546 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8582

  1. Oli Bartsch uploaded patch set 3 01/04/21, 13:09

  2. TYPO3com voted on patch set 3 V -1 01/04/21, 13:23 Completed build in 12m 51s on Mon, 4 Jan, 01:23 PM Test Summary: 1 of 32787 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8586

  3. Benni Mack uploaded patch set 4 01/05/21, 10:56

  4. TYPO3com voted on patch set 4 V -1 01/05/21, 11:10 Completed build in 13m 59s on Tue, 5 Jan, 11:10 AM Test Summary: 10387 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8619

  5. Oli Bartsch uploaded patch set 5 01/05/21, 11:33

  6. TYPO3com voted on patch set 5 V -1 01/05/21, 11:44 Completed build in 11m 05s on Tue, 5 Jan, 11:44 AM Test Summary: 2 of 26379 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8620

  7. Benni Mack uploaded patch set 6 01/05/21, 12:02

  8. TYPO3com voted on patch set 6 V -1 01/05/21, 12:13 Completed build in 10m 02s on Tue, 5 Jan, 12:13 PM Test Summary: 1 of 30792 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8621

  9. Benni Mack uploaded patch set 7 01/05/21, 13:15

  10. TYPO3com voted on patch set 7 V -1 01/05/21, 13:26 Completed build in 10m 59s on Tue, 5 Jan, 01:26 PM Test Summary: 1 of 32786 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8624

  11. Benni Mack uploaded patch set 8 03/15/21, 12:54

  12. TYPO3com voted on patch set 8 V +1 03/15/21, 13:03 Completed build in 08m 46s on Mon, 15 Mar, 01:03 PM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10140

  13. core-ci voted on patch set 8 V -1 03/15/21, 13:11 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1553

  14. Benni Mack uploaded patch set 9 05/04/21, 17:46

  15. core-ci voted on patch set 9 V -1 05/04/21, 17:56 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11141

  16. Benni Mack uploaded patch set 10 06/12/21, 19:03

  17. core-ci voted on patch set 10 V +1 06/12/21, 19:15 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12339

  18. Benni Mack uploaded patch set 11 06/14/21, 08:48

  19. core-ci voted on patch set 11 V +1 06/14/21, 08:55 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12389

  20. Oli Bartsch uploaded patch set 12 06/14/21, 09:24

  21. core-ci voted on patch set 12 V +1 06/14/21, 09:36 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12392

  22. Oli Bartsch voted on patch set 12 V +1 CR +1 06/14/21, 09:37

  23. Christian Kuhn commented on patch set 12 CR -1 06/14/21, 10:11

    on it.
  24. Christian Kuhn voted on patch set 12 V +2 CR +2 06/14/21, 10:21

  25. Christian Kuhn merged patch set 13 06/14/21, 10:21