67244[BUGFIX] Remove black line below table headings
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Andreas Kienast +1
-
Verified V +2 Done
- Richard Haeser +2
- Riccardo De Contardi +1
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 4
Review log 810
-
Benjamin Franzke uploaded patch set 1 12/22/20, 20:35
-
TYPO3com voted on patch set 1 V +1 12/22/20, 20:45 Completed build in 10m 16s on Tue, 22 Dec, 08:45 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8446
-
Benjamin Franzke uploaded patch set 2 12/22/20, 20:52
-
TYPO3com voted on patch set 2 V +1 12/22/20, 21:03 Completed build in 10m 26s on Tue, 22 Dec, 09:03 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8448
-
Christian Kuhn commented on patch set 2 12/22/20, 21:04
funny. i actually like the hard line below table heading - they give a good anchor for the eye to quickly see relevant sections. quite well visible in list & filelist view. but hey, i'm not a ux person, so i'll not vote, or vote on technical correctness. -
Benjamin Franzke commented on patch set 2 12/22/20, 22:14
Reply
Hehe, lol.. I see what you mean, but I think that does only fit for non-bordered tables. This black line doesn't fit for bordered tables like TYPO3 backend uses. See also: https://getbootstrap.com/docs/5.0/content/tables/#table-borders here the border is removed as well. Maybe we should migrate to that markup and remove alot of custom table css, but that's something for later.. -
Andreas Kienast voted on patch set 2 V +1 CR +1 12/23/20, 06:54
-
Riccardo De Contardi commented on patch set 2 V +1 12/26/20, 16:21
tested on latest master with list view; filelist, ext manager -
Richard Haeser voted on patch set 2 V +2 CR +2 12/29/20, 14:34
-
Richard Haeser merged patch set 3 12/29/20, 14:34