67246[TASK] Remove jQuery from most of EXT:filelist
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Richard Haeser +2
- Benjamin Franzke +1
- TYPO3com +1 CI
Issues 1
Files 15
- Build/Sources/TypeScript/filelist/Resources/Public/TypeScript/CreateFolder.ts+2 −2
- Build/Sources/TypeScript/filelist/Resources/Public/TypeScript/FileDelete.ts+12 −12
- Build/Sources/TypeScript/filelist/Resources/Public/TypeScript/FileList.ts2+35 −30
- Build/Sources/TypeScript/filelist/Resources/Public/TypeScript/FileListLocalisation.ts+7 −6
- Build/Sources/TypeScript/filelist/Resources/Public/TypeScript/FileReplace.ts+4 −1
- Build/Sources/TypeScript/filelist/Resources/Public/TypeScript/FileSearch.ts+3 −3
- Build/Sources/TypeScript/filelist/Resources/Public/TypeScript/RenameFile.ts2+59 −55
- typo3/sysext/filelist/Classes/FileList.php+2 −2
- typo3/sysext/filelist/Resources/Public/JavaScript/CreateFolder.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/FileDelete.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/FileList.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/FileListLocalisation.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/FileReplace.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/FileSearch.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/RenameFile.js+1 −1
Review log 68
-
Andreas Kienast uploaded patch set 1 12/23/20, 09:15
-
TYPO3com voted on patch set 1 V +1 12/23/20, 09:25 Completed build in 09m 52s on Wed, 23 Dec, 09:25 AM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8453
-
Benjamin Franzke commented on patch set 1 CR +1 12/23/20, 12:45
RenameFile.ts:31Maybe check for existence of document.querySelector('.t3js-submit-file-rename') and wait for document ready? (yes I know, it wasn't there before, but still, the module is loaded asynchronously in head, so it could happen..) -
Benjamin Franzke uploaded patch set 2 12/24/20, 06:32
-
Benjamin Franzke commented on patch set 2 12/24/20, 06:32
FileList.ts:86ReplyNevermind, I think this is fine in case we add buttons for newly uploaded files at some point. (which would be good)RenameFile.ts:31ReplyDone -
TYPO3com voted on patch set 2 V +1 12/24/20, 06:41 Completed build in 08m 33s on Thu, 24 Dec, 06:41 AM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8460
-
Richard Haeser commented on patch set 2 V +2 CR +2 12/29/20, 14:49
I have an issue with the text of the modal popping up when deleting a file, but that is not related to this change. -
Richard Haeser merged patch set 3 12/29/20, 14:50
FileList.ts:86