Review main Merged

67246[TASK] Remove jQuery from most of EXT:filelist

Andreas Kienast CR +2 V +2 Normal +131 −118 updated 12/29/20, 14:50

Commit message

With this change, most of the jQuery-based code is migrated to either
native APIs or substitutes provided by TYPO3.
The ContextMenu is not touched here as the base implementation heavily
relies on jQuery.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Benjamin Franzke +1
    • TYPO3com +1 CI

Issues 1

Files 15

Review log 68

  1. Andreas Kienast uploaded patch set 1 12/23/20, 09:15

  2. TYPO3com voted on patch set 1 V +1 12/23/20, 09:25 Completed build in 09m 52s on Wed, 23 Dec, 09:25 AM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8453

  3. Benjamin Franzke commented on patch set 1 CR +1 12/23/20, 12:45

    FileList.ts:86

    Maybe use document.querySelector('a.btn.filelist-file-info').forEach + bindTo here, to avoid binding to document? Or do you intend this to be used for newly uploaded files at some point?

    RenameFile.ts:31

    Maybe check for existence of document.querySelector('.t3js-submit-file-rename') and wait for document ready? (yes I know, it wasn't there before, but still, the module is loaded asynchronously in head, so it could happen..)
  4. Benjamin Franzke uploaded patch set 2 12/24/20, 06:32

  5. Benjamin Franzke commented on patch set 2 12/24/20, 06:32

    FileList.ts:86 Reply

    Nevermind, I think this is fine in case we add buttons for newly uploaded files at some point. (which would be good)

    RenameFile.ts:31 Reply

    Done
  6. TYPO3com voted on patch set 2 V +1 12/24/20, 06:41 Completed build in 08m 33s on Thu, 24 Dec, 06:41 AM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8460

  7. Richard Haeser commented on patch set 2 V +2 CR +2 12/29/20, 14:49

    I have an issue with the text of the modal popping up when deleting a file, but that is not related to this change.
  8. Richard Haeser merged patch set 3 12/29/20, 14:50