67247[BUGFIX] Use `form-select` class for <select> fields
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Martin Kutschker +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Martin Kutschker +1
- TYPO3com +1 CI
Issues 1
Files 67
- Build/Sources/Sass/typo3/_main_form.scss8+4 −39
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/DragUploader.ts+2 −2
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+1 −1
- typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/GroupElement.php+2 −9
- typo3/sysext/backend/Classes/Form/Element/InputColorPickerElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/InputLinkElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/InputTextElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/SelectMultipleSideBySideElement.php+4 −10
- typo3/sysext/backend/Classes/Form/Element/SelectSingleBoxElement.php3+3 −3
- typo3/sysext/backend/Classes/Form/Element/SelectSingleElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/TextElement.php+1 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+2 −2
- typo3/sysext/backend/Classes/View/PageLayoutView.php+1 −1
- typo3/sysext/backend/Resources/Private/Partials/Login/InterfaceSelector.html+1 −1
- typo3/sysext/backend/Resources/Private/Partials/Menus/SelectBoxJumpMenu.html+1 −1
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/LanguageColumns.html+1 −1
- typo3/sysext/backend/Resources/Private/Templates/Page/NewPages.html+1 −1
- typo3/sysext/backend/Resources/Private/Templates/ShortcutToolbarItem/EditForm.html+1 −1
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
Show 47 more files
- typo3/sysext/backend/Resources/Public/JavaScript/DragUploader.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine.js+1 −1
- typo3/sysext/belog/Resources/Private/Partials/Content/Filter.html+8 −8
- typo3/sysext/beuser/Resources/Private/Partials/Filters/BackendUser/Index.html+5 −5
- typo3/sysext/beuser/Resources/Private/Partials/SimplePagination.html+1 −1
- typo3/sysext/beuser/Resources/Private/Templates/Permission/Edit.html+3 −3
- typo3/sysext/beuser/Resources/Private/Templates/Permission/Index.html+1 −1
- typo3/sysext/core/Classes/Database/QueryGenerator.php+8 −8
- typo3/sysext/core/Classes/Database/QueryView.php+1 −1
- typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php+1 −1
- typo3/sysext/core/Classes/ViewHelpers/Form/TypoScriptConstantsViewHelper.php+1 −1
- typo3/sysext/extensionmanager/Resources/Private/Templates/List/Ter.html+1 −1
- typo3/sysext/filelist/Resources/Private/Templates/File/CreateFolder.html+1 −1
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/FinishersEditor.html+1 −1
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/MultiSelectEditor.html+1 −1
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/SingleSelectEditor.html+1 −1
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/ValidatorsEditor.html+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/Backend/FormManager/ViewModel.js+4 −4
- typo3/sysext/impexp/Resources/Private/Partials/Export/AdvancedOptions.html+1 −1
- typo3/sysext/impexp/Resources/Private/Partials/Export/Configuration.html+4 −4
- typo3/sysext/impexp/Resources/Private/Partials/Export/Save.html+2 −2
- typo3/sysext/impexp/Resources/Private/Partials/Import/Import.html+1 −1
- typo3/sysext/install/Resources/Private/Partials/Settings/LocalConfiguration/SubSection.html+1 −1
- typo3/sysext/install/Resources/Private/Templates/Installer/ShowDatabaseConnect.html+1 −1
- typo3/sysext/install/Resources/Private/Templates/Installer/ShowDatabaseSelect.html+1 −1
- typo3/sysext/linkvalidator/Classes/Task/ValidatorTaskAdditionalFieldProvider.php+1 −1
- typo3/sysext/linkvalidator/Resources/Private/Layouts/TabContent.html+1 −1
- typo3/sysext/lowlevel/Classes/Database/QueryGenerator.php+9 −9
- typo3/sysext/recordlist/Classes/Controller/AbstractLinkBrowserController.php+1 −1
- typo3/sysext/recordlist/Classes/Controller/RecordListController.php+1 −1
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+1 −1
- typo3/sysext/recordlist/Resources/Private/Templates/Search.html+1 −1
- typo3/sysext/recycler/Classes/Task/CleanerFieldProvider.php+1 −1
- typo3/sysext/recycler/Resources/Private/Templates/RecyclerModule/Index.html+2 −2
- typo3/sysext/redirects/Resources/Private/Partials/Pagination.html4+1 −1
- typo3/sysext/redirects/Resources/Private/Templates/Management/Overview.html+4 −4
- typo3/sysext/rte_ckeditor/Classes/Controller/BrowseLinksController.php+2 −2
- typo3/sysext/scheduler/Classes/Task/CachingFrameworkGarbageCollectionAdditionalFieldProvider.php+1 −1
- typo3/sysext/scheduler/Classes/Task/ExecuteSchedulableCommandAdditionalFieldProvider.php+1 −1
- typo3/sysext/scheduler/Classes/Task/FileStorageExtractionAdditionalFieldProvider.php+1 −1
- typo3/sysext/scheduler/Classes/Task/FileStorageIndexingAdditionalFieldProvider.php+1 −1
- typo3/sysext/scheduler/Classes/Task/IpAnonymizationAdditionalFieldProvider.php+2 −2
- typo3/sysext/scheduler/Classes/Task/OptimizeDatabaseTableAdditionalFieldProvider.php+1 −1
- typo3/sysext/scheduler/Classes/Task/TableGarbageCollectionAdditionalFieldProvider.php+1 −1
- typo3/sysext/scheduler/Resources/Private/Templates/Backend/SchedulerModule/EditTask.html+4 −4
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+6 −3
- typo3/sysext/workspaces/Resources/Private/Partials/WorkingTable.html+5 −5
Review log 2939
Show 914 earlier messages
-
Andreas Kienast uploaded patch set 1 12/23/20, 09:35
-
TYPO3com voted on patch set 1 V -1 12/23/20, 09:47 Completed build in 10m 58s on Wed, 23 Dec, 09:47 AM Test Summary: 31472 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8454
-
Andreas Kienast uploaded patch set 2 12/23/20, 10:52
-
TYPO3com voted on patch set 2 V -1 12/23/20, 11:03 Completed build in 10m 44s on Wed, 23 Dec, 11:03 AM Test Summary: 1 of 32781 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8455
-
TYPO3com voted on patch set 2 V +1 12/23/20, 11:32 Completed build in 50m 34s on Wed, 23 Dec, 11:32 AM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8455
-
Oliver Klee updated the commit message in patch set 3 12/23/20, 16:07
-
TYPO3com voted on patch set 3 V +1 12/23/20, 16:17 Completed build in 09m 49s on Wed, 23 Dec, 04:17 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8459
-
Andreas Kienast uploaded patch set 4 12/28/20, 12:47
-
Guido Schmechel commented on patch set 4 12/28/20, 12:53
-
TYPO3com voted on patch set 4 V +1 12/28/20, 12:58 Completed build in 10m 12s on Mon, 28 Dec, 12:58 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8471
-
Guido Schmechel commented on patch set 4 12/28/20, 13:08
Pagination.html:49ReplyOkay. I can live with it being in the commit message ;-) -
Andreas Kienast commented on patch set 4 12/28/20, 13:08
Pagination.html:49ReplyYes and no. Strictly speaking, you're right. OTOH, I have to fix these occurrences for select fields as well, anyway. I have no strong opinion here, whether we keep these changes or push a new patch. -
Guido Schmechel voted on patch set 4 V +1 CR +1 12/28/20, 13:08
-
Benjamin Franzke wrote 12/28/20, 19:57
Topic set to bootstrap5
-
Benjamin Franzke commented on patch set 4 CR -1 12/28/20, 20:04
There are still some occurrences left. Please checkout: git grep "select.*form-control" | grep -v -E "backend.css|form.css|__esModule" | sed 's/:.*//' | uniq Build/Sources/Sass/typo3/_main_form.scss Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/SelectSingleElement.ts typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php typo3/sysext/backend/Classes/Form/Element/SelectMultipleSideBySideElement.php typo3/sysext/backend/Classes/Form/Element/SelectSingleElement.php typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/SelectSingleElement.js typo3/sysext/form/Resources/Public/JavaScript/Backend/FormManager/ViewModel.js typo3/sysext/scheduler/Classes/Task/ExecuteSchedulableCommandAdditionalFieldProvider.php -
Andreas Kienast commented on patch set 4 12/29/20, 10:19
Reply
Thanks a lot for that list. Some of the results are false-positives, as there is also a class called `form-control-wrap`. -
Andreas Kienast uploaded patch set 5 12/29/20, 10:19
-
TYPO3com voted on patch set 5 V +1 12/29/20, 10:30 Completed build in 11m 02s on Tue, 29 Dec, 10:30 AM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8490
-
Martin Kutschker commented on patch set 5 12/29/20, 20:54
SelectSingleBoxElement.php:172This is the only file where the classes tceforms-select and tceforms-multiselect have not been removed. A slip? -
Martin Kutschker uploaded patch set 6 12/29/20, 21:01
-
TYPO3com voted on patch set 6 V +1 12/29/20, 21:11 Completed build in 09m 55s on Tue, 29 Dec, 09:11 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8496
-
Andreas Kienast commented on patch set 6 12/30/20, 06:56
SelectSingleBoxElement.php:172ReplyThis was kept on purpose, those strings aren't used as CSS classes anymore, but as a prefix for its id attribute. -
Martin Kutschker commented on patch set 6 CR +1 12/30/20, 10:24
SelectSingleBoxElement.php:172ReplyAck -
Benjamin Franzke uploaded patch set 7 12/30/20, 16:16
-
TYPO3com voted on patch set 7 V +1 12/30/20, 16:26 Completed build in 09m 48s on Wed, 30 Dec, 04:26 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8509
-
Benjamin Franzke commented on patch set 7 12/30/20, 16:27
Reply
Yup, thanks for taking care._main_form.scss:194Does someone know why "width: 100% !important" is needed specially for fields with a size/multiple attribute? What makes them special to a regular select field? This means following will yield different stylings: <select class="form-select" size="1"></select> <select class="form-select"></select> This seems wrong and caused problems for pages.backend_layout (the input-group was wrapped because the select didn't properly flex because this 100% width). I have therefore added :not(.form-control-adapt) in patchset 7 to fix those fields where this class really explicitly asks for non-100% width, but better would be to remove this definitions.. History: it was introduced back in 2015 when FormEngine components where adapted to use bootstrap https://review.typo3.org/c/Packages/TYPO3.CMS/+/35951/35/typo3/sysext/t3skin/Resources/Private/Styles/TYPO3/_main_form.less#64 – so I guess some special TCA thing may need(ed) this, but which? :) -
Andreas Kienast commented on patch set 7 12/31/20, 11:35
_main_form.scss:194ReplyThat's a really good question. I _think_ the original purpose in FormEngine was to require a full width for all select fields to have a consistent look&feel. IIRC FormEngine also always renders a size attribute, so it's pinned to that. -
Martin Kutschker commented on patch set 7 01/01/21, 19:34
_main_form.scss:194ReplyI'm in the no-important camp, but I think if you add a comment .form-control-adapt to mark it as a temporary solution, it is ok. The patch is large enough. No need to make it more hzardous by removing a seemingly obsolete important. -
Benjamin Franzke uploaded patch set 8 01/04/21, 06:27
-
Benjamin Franzke commented on patch set 8 01/04/21, 06:27
_main_form.scss:194ReplyAs this definition is just wrong and incompatible with bootstrap 5 css, I've now removed it. A select box is width 100% by default, so it's really not needed. And I don't want to introduce guessing comments here – if it really causes a bug, then that should be fixed later on with a more specific CSS selector, not a generic one, that attaches to *all* select fields. -
Benjamin Franzke commented on patch set 8 01/04/21, 06:29
_main_form.scss:194ReplyDonePagination.html:49ReplyI'd also agree, that this is fine to be done as drive-by. -
TYPO3com voted on patch set 8 V -1 01/04/21, 06:38 Completed build in 10m 24s on Mon, 4 Jan, 06:38 AM Test Summary: 1 of 32787 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8572
-
TYPO3com voted on patch set 8 V +1 01/04/21, 07:00 Completed build in 09m 05s on Mon, 4 Jan, 07:00 AM Test Summary: 32546 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8574
-
Martin Kutschker commented on patch set 8 01/04/21, 09:33
_main_form.scss:194ReplyOK. -
Benjamin Franzke commented on patch set 8 01/04/21, 09:36
_main_form.scss:194ReplyDid you mark it unresolved by intention? I guess that was by accident. Marking resolved again ;) -
Martin Kutschker commented on patch set 8 01/04/21, 13:05
_main_form.scss:194ReplySorry, I thought that the checkbox is part of my message, not the state of the wohle thread. -
Martin Kutschker voted on patch set 8 V +1 CR +1 01/04/21, 13:38
-
Benjamin Franzke voted on patch set 8 V +2 CR +2 01/04/21, 13:53
-
Benjamin Franzke merged patch set 9 01/04/21, 13:53
Pagination.html:49