Review 9.5 Merged

67299[BUGFIX] Fix image processing hint in install tool

Benni Mack CR +2 V +2 Easy +1 −1 updated 01/04/21, 14:20

Commit message

The setting $GLOBALS['TYPO3_CONF_VARS']['GFX']['colorspace'] is
deprecated since TYPO3 8.0 and is now replaced with
$GLOBALS['TYPO3_CONF_VARS']['GFX']['processor_colorspace']

Since the hint now is too long, a manual linebreak has been added
to avoid the automatic linebreak which adds a minus char to the
processor_colorspace text.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 57

  1. Benni Mack commented on patch set 1 01/04/21, 13:57

    Cherry Picked from branch 10.4. The following files contain Git conflicts: * typo3/sysext/install/Resources/Private/Templates/Environment/ImageProcessing.html
  2. Benni Mack commented on patch set 2 01/04/21, 13:58

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 01/04/21, 13:58

  4. TYPO3com voted on patch set 1 V +1 01/04/21, 14:10 Completed build in 13m 23s on Mon, 4 Jan, 02:10 PM Test Summary: 75346 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-949

  5. TYPO3com voted on patch set 2 V +1 01/04/21, 14:17 Completed build in 15m 51s on Mon, 4 Jan, 02:17 PM Test Summary: 75346 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-950

  6. Benni Mack voted on patch set 2 V +2 CR +2 01/04/21, 14:20

  7. Benni Mack merged patch set 3 01/04/21, 14:20