Review 10.4 Merged

67300[BUGFIX] Reduce ses_id field length

Benni Mack CR +2 V +2 Easy +2 −2 updated 01/04/21, 16:43

Commit message

The patch for #93131 increased the db size of field ses_id
in tables fe_sessions and be_sessions from 32 to 255 chars.
The field is the tables primary key.
With mysql/mariadb, if the table is created on an older db
engine version that creates innodb tables with COMPACT
row format using utf8_mb4 charset, the key length now
exceeds the COMPACT maximum index length restrition of 767
bytes: 4*255+1 = 1021 bytes
Since we don't strictly need a varchar(255), the patch
reduces the field to 190, which does not collide with
maximum key length restrictions: 4*190+1 = 761 bytes

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 34

  1. Benni Mack commented on patch set 1 01/04/21, 15:44

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 01/04/21, 15:56 Completed build in 11m 34s on Mon, 4 Jan, 03:56 PM Test Summary: 75274 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-951

  3. Benni Mack voted on patch set 1 V +2 CR +2 01/04/21, 16:43

  4. Benni Mack merged patch set 2 01/04/21, 16:43