Review 10.4 Merged

67305[BUGFIX] Use custom image file extensions for image processing tests

Christian Kuhn CR +2 V +2 Easy +14 −2 updated 01/06/21, 11:36

Commit message

If an integrator removes image file extensions, e.g. "gif", from
$GLOBALS['TYPO3_CONF_VARS']['GFX']['imagefile_ext'] the whole image
processing test in the install tool fails.

That's because some tests need to run independent of the global
configuration. Therefore the GraphicalFunctions class, which is
used as the image processor, now features a setter. This allows
EXT:install to manually define required image extensions for the
tests, which should not consider the global configuration.

Note: The `convertImageFormatsToJpg` test, which tries to
convert every defined image file extension (based on the
global configuration) to JPG, is not affected by this change.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 34

  1. Christian Kuhn commented on patch set 1 01/06/21, 11:17

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 01/06/21, 11:33 Completed build in 15m 27s on Wed, 6 Jan, 11:33 AM Test Summary: 75280 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-963

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 01/06/21, 11:35

  4. Christian Kuhn merged patch set 2 01/06/21, 11:36