Review 10.4 Merged

67306[BUGFIX] Streamline frontend 5xx error handling

Christian Kuhn CR +2 V +2 Normal +176 −32 updated 01/06/21, 13:36

Commit message

* Fix 500 vs 503 error for configuration vs maintenance errors
 * Fix maintenance mode middleware ordering to get access to site
   related error handlers
 * Fix ErrorController unit tests to actually test
   for 503 and 500 error responses (contained duplicate
   code that didn't actually test for the non-configured
   state, but the devIPMask state)

For 5xx status code we have two different cases right now:
 * configuration errors, which need to respond with 500
 * maintenance mode, which is a 503 response

Therefore TSFE now uses internalErrorAction()
to respond with "500 Internal Server Error" when
the page configuration is broken.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 2

Files 6

Review log 57

  1. Christian Kuhn commented on patch set 1 01/06/21, 11:48

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 01/06/21, 12:02 Completed build in 14m 02s on Wed, 6 Jan, 12:02 PM Test Summary: 3 of 75789 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-964

  3. Benjamin Franzke uploaded patch set 2 01/06/21, 13:17

  4. TYPO3com voted on patch set 2 V +1 01/06/21, 13:30 Completed build in 13m 15s on Wed, 6 Jan, 01:30 PM Test Summary: 75304 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-967

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 01/06/21, 13:35

  6. Benjamin Franzke voted on patch set 2 V +2 CR +2 01/06/21, 13:36

  7. Benjamin Franzke merged patch set 3 01/06/21, 13:36