67313[TASK] Use core AjaxRequest instead d3.request
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 2
Files 6
- Build/Gruntfile.js+1 −6
- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTree.js2+114 −114
- typo3/sysext/backend/Resources/Public/JavaScript/SvgTree.js+14 −9
- typo3/sysext/core/Classes/Page/PageRenderer.php+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/d3/d3.jsdeleted+0 −9
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/d3.jsnew+2 −0
Review log 1015
-
Benjamin Franzke uploaded patch set 1 12/30/20, 09:38
-
TYPO3com voted on patch set 1 V -1 12/30/20, 09:47 Completed build in 09m 38s on Wed, 30 Dec, 09:47 AM Test Summary: 76 of 32781 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8501
-
TYPO3com commented on patch set 1 12/30/20, 10:35 Completed build in 11m 02s on Wed, 30 Dec, 10:35 AM Test Summary: 76 of 32781 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8504
-
Benjamin Franzke uploaded patch set 2 12/30/20, 10:47
-
TYPO3com voted on patch set 2 V +1 12/30/20, 10:57 Completed build in 10m 00s on Wed, 30 Dec, 10:57 AM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8506
-
Benjamin Franzke marked it work in progress 12/30/20, 12:09
-
Benjamin Franzke commented on patch set 2 CR -1 12/30/20, 12:09
This change is ready for review.PageTree.js:172Not sure here, we could also use core AjaxRequest (which also uses native fetch) instead of adapting for the d3.json()/text() changes. And then we may just also use the smaller subpackages of d3, als the library is HUGE. -
Benjamin Franzke marked it work in progress 12/30/20, 12:10
-
Benjamin Franzke uploaded patch set 3 12/31/20, 11:20
-
Benjamin Franzke commented on patch set 3 12/31/20, 11:20
PageTree.js:172Replysmaller subpackages of d3 are only useful with d3 v6, as events still require a d3 global in v5. But we could switch to AjaxRequest and stay with v4 but revert to vanilla v4. -
Andreas Kienast commented on patch set 3 V +1 CR +1 12/31/20, 11:28
<3 -
TYPO3com voted on patch set 3 V -1 12/31/20, 11:37 Completed build in 16m 04s on Thu, 31 Dec, 11:37 AM Test Summary: 1 of 31037 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8523
-
TYPO3com voted on patch set 3 V +1 12/31/20, 11:45 Completed build in 40m 08s on Thu, 31 Dec, 11:45 AM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8523
-
Benni Mack voted on patch set 3 V +2 CR +2 01/01/21, 13:54
-
Benni Mack merged patch set 4 01/01/21, 13:54