Review main Merged

67313[TASK] Use core AjaxRequest instead d3.request

Benjamin Franzke CR +2 V +2 Hard +132 −139 updated 01/01/21, 13:54

Commit message

d3 is currently manually patched to avoid a
d3.request()/d3.json() bug in chome >= 64 – see #83741.
The patch has not been merged in two years, and d3.request
is deprecated, so it is now replaced.
This will also help to upgrade to D3.js v5/v6 at some
point.

This allows to use an unpatched, vanilla D3.js build again.
While at it, we also streamline the contrib path to avoid the
unecessary d3/ subdirectory.

Commands used:

  grunt build

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 2

Files 6

Review log 1015

  1. Benjamin Franzke uploaded patch set 1 12/30/20, 09:38

  2. TYPO3com voted on patch set 1 V -1 12/30/20, 09:47 Completed build in 09m 38s on Wed, 30 Dec, 09:47 AM Test Summary: 76 of 32781 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8501

  3. TYPO3com commented on patch set 1 12/30/20, 10:35 Completed build in 11m 02s on Wed, 30 Dec, 10:35 AM Test Summary: 76 of 32781 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8504

  4. Benjamin Franzke uploaded patch set 2 12/30/20, 10:47

  5. TYPO3com voted on patch set 2 V +1 12/30/20, 10:57 Completed build in 10m 00s on Wed, 30 Dec, 10:57 AM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8506

  6. Benjamin Franzke marked it work in progress 12/30/20, 12:09

  7. Benjamin Franzke commented on patch set 2 CR -1 12/30/20, 12:09

    This change is ready for review.

    PageTree.js:172

    Not sure here, we could also use core AjaxRequest (which also uses native fetch) instead of adapting for the d3.json()/text() changes. And then we may just also use the smaller subpackages of d3, als the library is HUGE.
  8. Benjamin Franzke marked it work in progress 12/30/20, 12:10

  9. Benjamin Franzke uploaded patch set 3 12/31/20, 11:20

  10. Benjamin Franzke commented on patch set 3 12/31/20, 11:20

    PageTree.js:172 Reply

    smaller subpackages of d3 are only useful with d3 v6, as events still require a d3 global in v5. But we could switch to AjaxRequest and stay with v4 but revert to vanilla v4.
  11. Andreas Kienast commented on patch set 3 V +1 CR +1 12/31/20, 11:28

    <3
  12. TYPO3com voted on patch set 3 V -1 12/31/20, 11:37 Completed build in 16m 04s on Thu, 31 Dec, 11:37 AM Test Summary: 1 of 31037 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8523

  13. TYPO3com voted on patch set 3 V +1 12/31/20, 11:45 Completed build in 40m 08s on Thu, 31 Dec, 11:45 AM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8523

  14. Benni Mack voted on patch set 3 V +2 CR +2 01/01/21, 13:54

  15. Benni Mack merged patch set 4 01/01/21, 13:54